Skip to content
This repository was archived by the owner on Jun 4, 2025. It is now read-only.

feat: add support to import music from local files - #103

Draft
eXhumer wants to merge 9 commits into
OMGDuke:mainfrom
eXhumer:new-changes
Draft

feat: add support to import music from local files#103
eXhumer wants to merge 9 commits into
OMGDuke:mainfrom
eXhumer:new-changes

Conversation

@eXhumer

@eXhumer eXhumer commented Dec 26, 2024

Copy link
Copy Markdown
Contributor

This is still not ready to be merged as stuff like checks when trying to import the same file twice needs to be added and other guardrails.

  • fix: better mime type guessing using mimetypes module
  • feat: add support to import music from local files
  • chore: upgrade dependencies
  • chore: upgrade yt-dlp to latest (2024.12.23)
  • style: fix eslint / prettier issues
  • style: replace direct console commands with intermediate logger object

Signed-off-by: eXhumer <exhumer@exhumer.cc>
* this change is to better understand which logs are coming from the plugin frontend

Signed-off-by: eXhumer <exhumer@exhumer.cc>
Signed-off-by: eXhumer <exhumer@exhumer.cc>
Signed-off-by: eXhumer <exhumer@exhumer.cc>
Signed-off-by: eXhumer <exhumer@exhumer.cc>
* also adds a check for non-audio mimetypes

Signed-off-by: eXhumer <exhumer@exhumer.cc>
* this file extension is actually associated with mimetype video/webm, but yt-dlp downloads OPUS audio files as webm still
* when using Invidious, the plugin assumes the extension to be webm as well, a change is included to it be weba extension

Signed-off-by: eXhumer <exhumer@exhumer.cc>
Signed-off-by: eXhumer <exhumer@exhumer.cc>
Signed-off-by: eXhumer <exhumer@exhumer.cc>
@TheMangoLad1415

Copy link
Copy Markdown

Any updates on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants