This repository was archived by the owner on Jun 4, 2025. It is now read-only.
feat: Custom Default Search Keywords - #110
Open
kipuki wants to merge 11 commits into
Open
Conversation
Added a TextInputModal that extends ConfirmModal to allow for text input.
This was done to prevent new settings keys from being unset as it happened with defaultSearchQuery.
Settings name for query fit as keywords fit more.
Change theme page and auto-fetch audio now use the currently set default search keywords. This change required that some refactoring be done. searchTerm state had to be lifted to the parent for better control.
Beginner mistake. Resolver could not fetch the settings because the useSettings() hook was being called from within a class function. It has now been restructured to allow the keyword to be passed through the getAudio() function.
Removed an unnecessary call to customSearch() where the search would've been peformed twice. Renamed setInitialSearch() to defaultSearch() as the name was more clear.
kipuki
marked this pull request as ready for review
April 12, 2025 04:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the ability for users to customize the default keywords appended to game titles. This feature was originally suggested in Issue #30 , and I wanted to contribute since it's also something I personally found useful.
Changes
ConfirmModalto allow users to make add text inputs. This is used to allow the user to change the default keywords.Notes
I am still relatively new to TypeScript, but I really wanted to contribute to the project as it is one of my favorite plugins. Please let me know if there is anything you'd like me to change or improve! I hope to contribute more soon!