Implemented Cullum/Willoughby method for removing spurious eigenvalues.#180
Conversation
ghost
assigned
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=========================================
+ Coverage 87.16% 87.3% +0.14%
=========================================
Files 53 53
Lines 2851 2891 +40
=========================================
+ Hits 2485 2524 +39
- Misses 366 367 +1
Continue to review full report at Codecov.
|
|
So can we close #143? |
No, we have not solved all the issues, and Wayne will continue using it for the development. This PR is simply cleaning up that and merging so that we have something better than what we have right now. |
|
What's with the @ghost account assigning labels? Something happened to waffle? |
|
Yeah Waffle is dead. Got an email a month ago saying that they would close. |
Rombur
left a comment
Rombur
left a comment
There was a problem hiding this comment.
You need to rebase this branch.
| for (int i = 0; i < n; ++i) | ||
| { | ||
| is_repeated[i] = ((i > 0 && (evals[i] <= evals[i - 1] + tol2)) || | ||
| (i < n - 1 && (evals[i + 1] <= evals[i] + tol2))); |
There was a problem hiding this comment.
Can you add a comment on this condition. This is really hard to read.
| { | ||
| is_repeated[i] = ((i > 0 && (evals[i] <= evals[i - 1] + tol2)) || | ||
| (i < n - 1 && (evals[i + 1] <= evals[i] + tol2))); | ||
| is_marked[i] = (i == 0 || (evals[i] > evals[i - 1] + tol2)); |
|
Rebased and added comments. |
5 participants
This is a cleanup of #143. It is to be served as to improve status quo while continuing investigation of potential issues in that PR.