fix(output): include report.json and OA/DM panels in multi-folder HTML report - #938
Closed
RohithPariki wants to merge 1 commit into
Closed
fix(output): include report.json and OA/DM panels in multi-folder HTML report#938RohithPariki wants to merge 1 commit into
RohithPariki wants to merge 1 commit into
Conversation
Collaborator
|
Thanks @RohithPariki. This overlaps #901, which is already open and implementing the multi-folder report.json + OA/DM panels. To keep priority with the original author I will close this as a duplicate - but if you would like to help, reviewing or testing #901 would be genuinely useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the multi-folder HTML reporter to generate the
report.jsondata payload and aggregate override/maintenance findings, ensuring parity with the single-folder HTML report.Problem
When running scans in multi-folder mode with
--report, the generated HTML output was missing the embeddedreport.jsonpayload. Additionally, it failed to render the override findings (OA) and maintenance risk (DM) panels, making the multi-folder dashboard incomplete compared to single-folder runs.Root Cause
The
writeMultiFolderHtmlReportfunction was not explicitly accumulating and passing theoverrideFindingsandmaintenanceFindingsarrays from the individual subfolder scan results into the HTML generation template, nor was it embedding the serializedreport.jsondata.Solution
overrideFindingsandmaintenanceFindingsacross allMultiFolderScanResultobjects.report.jsondata block for multi-folder runs.Testing & Verification
cve-lite . --reportin a multi-folder workspace now successfully generates thereport.jsonscript tag in the HTML.npm testsuite to ensure no regressions in output or reporter logic.References
Closes #878