Fix dead link checker: correct www.github.com URLs and exclude internal routes #2339

Copilot · 2025-12-02T08:57:42Z

What kind of changes does this PR include?

Fixes or refactors
A new challenge
Additional documentation
Something else

Description

The dead link checker was failing due to 141+ invalid GitHub URLs using the www subdomain, which doesn't exist for github.com, and lychee attempting to validate internal application routes.

Changes:

Fixed https://www.github.com/ → https://github.com/ across:
- src/main/resources/templates/welcome.html (48 URLs)
- static-site/pr-2125/pages/welcome.html (48 URLs)
- README.md (45+ URLs in contributors + LinkedIn share link)
Added Docker Hub exclusion to .lycheeignore (returns 403 Forbidden)
Added regex pattern ^/[^/].* to .lycheeignore to exclude internal application routes (e.g., /challenge/challenge-1, /images/screenshot.png) from link validation

Impact:
Link checker errors reduced from 248 to 112. The InvalidPathToUri warnings for internal routes are now eliminated by excluding them from validation.

Relations

Closes #2338

References

N/A

Checklist:

All the contributions made are solely the work of me and my co-authors
I used AI to generate parts of the content.
I tested the changes in this PR (if applicable)
I added unit tests to ensure my change works (when change in Java or on front-end code)
I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
The PR passes pre-commit hooks and automated tests

Original prompt

This section details on the original issue you should resolve

<issue_title>The dead link checker is failing</issue_title>
<issue_description>The dead link checker is failing, can you please fix it?</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes The dead link checker is failing #2338

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: commjoen <[email protected]>

github-actions · 2025-12-02T09:23:35Z

🌐 GitHub Pages Preview Ready!

Your static preview is now available at:
🔗 Preview PR #2339

📄 What's included:

✅ All CSS, JavaScript, and static assets (embedded inline)
✅ Current styling and layout preview
✅ Images, icons, and UI components
✅ NEW: Generated HTML from Thymeleaf templates
- 🏠 Home/Welcome Page
- ℹ️ About Page
- 📊 Stats & Config Page
- 🤖 Challenge 57: LLM Security (Latest)
- 🧩 Challenge Example

For full functionality testing: Use the Docker preview instead.

🔄 Auto-updates: This preview will be updated automatically when you push new commits to this PR.

_{Static preview with Thymeleaf generation by GitHub Actions}

commjoen · 2025-12-02T09:23:37Z

@copilot we stil get
[WARN ] Error creating request: InvalidPathToUri("/images/screenshot.png")
[WARN ] Error creating request: InvalidPathToUri("/Dockerfile")
[WARN ] Error creating request: InvalidPathToUri("/Dockerfile.web")
[WARN ] Error creating request: InvalidPathToUri("/k8s/")
[WARN ] Error creating request: InvalidPathToUri("/okteto/")
[WARN ] Error creating request: InvalidPathToUri("/gcp/k8s-vault-gcp-ingress-start.sh")
[WARN ] Error creating request: InvalidPathToUri("/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge15.java")
[WARN ] Error creating request: InvalidPathToUri("/aws/k8s/secret-challenge-vault-deployment.yml")
[WARN ] Error creating request: InvalidPathToUri("/gcp/k8s/secret-challenge-vault-deployment.yml.tpl")
[WARN ] Error creating request: InvalidPathToUri("/.github/workflows/scanner-comparison.yml")
[WARN ] Error creating request: InvalidPathToUri("/docs/scanner-comparison.md")
[WARN ] Error creating request: InvalidPathToUri("/ctf-instructions.md")
[WARN ] Error creating request: InvalidPathToUri("/CONTRIBUTING.md")
[WARN ] Error creating request: InvalidPathToUri("/")
[WARN ] Error creating request: InvalidPathToUri("/")
[WARN ] Error creating request: InvalidPathToUri("/")
[WARN ] Error creating request: InvalidPathToUri("/")
[WARN ] Error creating request: InvalidPathToUri("/stats")
[WARN ] Error creating request: InvalidPathToUri("/stats")
[WARN ] Error creating request: InvalidPathToUri("/about")
[WARN ] Error creating request: InvalidPathToUri("/v3/api-docs")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-1")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-2")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-3")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-4")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-5")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-6")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-7")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-8")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-9")
[WARN ] Error creating request: InvalidPathToUri("/challenge/challenge-10")

Summary

Status	Count
🔍 Total	697
✅ Successful	383
⏳ Timeouts	0
🔀 Redirected	0
👻 Excluded	313
❓ Unknown	0
🚫 Errors	1
⛔ Unsupported	0
in https://github.com/OWASP/wrongsecrets/actions/runs/19853130288/job/56885653118?pr=2339

Co-authored-by: commjoen <[email protected]>

Copilot · 2025-12-02T09:25:54Z

@copilot we stil get
[WARN ] Error creating request: InvalidPathToUri("/images/screenshot.png")
[WARN ] Error creating request: InvalidPathToUri("/Dockerfile")
...

Fixed in commit 5cc4677. Added regex pattern ^/[^/].* to .lycheeignore to exclude internal application routes (relative paths starting with /) from link checking. This prevents the InvalidPathToUri warnings for paths like /challenge/challenge-1, /images/screenshot.png, etc.

github-actions · 2025-12-02T09:28:11Z

📸 Visual Diff Available!

Screenshots have been generated comparing your changes with the main branch.

Download Visual Diff Artifacts

The artifacts contain:

pr-home.png - Your version of the home page
main-home.png - Current main branch home page
pr-about.png - Your version of the about page
main-about.png - Current main branch about page

Compare these images to see the visual impact of your changes!

_{Visual diff generated by GitHub Actions}

github-actions · 2025-12-02T09:30:42Z

🔨 Preview Build Complete!

Your changes have been built and pushed to GitHub Container Registry.

🐳 Docker Image: ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2339-df45fe5

📦 Download & Test Locally:

📁 Download Docker Image Artifact (look for wrongsecrets-preview-pr-2339)
Load and run the image:

# Download the artifact, extract it, then:
docker load < wrongsecrets-preview.tar
docker run -p 8080:8080 wrongsecrets-preview

🚀 Alternative - Pull from Registry:

docker pull ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2339-df45fe5
docker run -p 8080:8080 ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2339-df45fe5

Then visit: http://localhost:8080

📝 Changes in this PR:
- src/main/resources/templates/welcome.html

Visual diff screenshots will be available shortly...

_{Preview built by GitHub Actions}

github-actions · 2025-12-02T09:33:39Z

📸 Visual Diff Ready!

Screenshots comparing your changes with the main branch are available:

📁 Download Visual Diff Artifacts

🖼️ Included screenshots:

pr-home.png vs main-home.png - Welcome page comparison
pr-about.png vs main-about.png - About page comparison
pr-challenge.png vs main-challenge.png - Challenge page comparison

🔍 How to review:

Download the artifact zip file
Extract and compare the pr-* and main-* images side by side
Look for visual differences in layout, styling, and content

💡 Tip: Use an image comparison tool or open both images in separate browser tabs to spot differences easily.

_{Visual diff generated by GitHub Actions • PR #2339}

github-actions · 2025-12-02T10:52:52Z

🌐 GitHub Pages Preview Ready!

Your static preview is now available at:
🔗 Preview PR #2339

📄 What's included:

✅ All CSS, JavaScript, and static assets (embedded inline)
✅ Current styling and layout preview
✅ Images, icons, and UI components
✅ NEW: Generated HTML from Thymeleaf templates
- 🏠 Home/Welcome Page
- ℹ️ About Page
- 📊 Stats & Config Page
- 🤖 Challenge 57: LLM Security (Latest)
- 🧩 Challenge Example

For full functionality testing: Use the Docker preview instead.

🔄 Auto-updates: This preview will be updated automatically when you push new commits to this PR.

_{Static preview with Thymeleaf generation by GitHub Actions}

github-actions · 2025-12-02T10:56:56Z

📸 Visual Diff Available!

Screenshots have been generated comparing your changes with the main branch.

Download Visual Diff Artifacts

The artifacts contain:

pr-home.png - Your version of the home page
main-home.png - Current main branch home page
pr-about.png - Your version of the about page
main-about.png - Current main branch about page

Compare these images to see the visual impact of your changes!

_{Visual diff generated by GitHub Actions}

github-actions · 2025-12-02T10:57:17Z

📸 Visual Diff Available!

Screenshots have been generated comparing your changes with the main branch.

Download Visual Diff Artifacts

The artifacts contain:

pr-home.png - Your version of the home page
main-home.png - Current main branch home page
pr-about.png - Your version of the about page
main-about.png - Current main branch about page

Compare these images to see the visual impact of your changes!

_{Visual diff generated by GitHub Actions}

github-actions · 2025-12-02T10:57:26Z

🔨 Preview Build Complete!

Your changes have been built and pushed to GitHub Container Registry.

🐳 Docker Image: ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2339-79c03c0

📦 Download & Test Locally:

📁 Download Docker Image Artifact (look for wrongsecrets-preview-pr-2339)
Load and run the image:

# Download the artifact, extract it, then:
docker load < wrongsecrets-preview.tar
docker run -p 8080:8080 wrongsecrets-preview

🚀 Alternative - Pull from Registry:

docker pull ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2339-79c03c0
docker run -p 8080:8080 ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2339-79c03c0

Then visit: http://localhost:8080

📝 Changes in this PR:
- src/main/resources/templates/welcome.html

Visual diff screenshots will be available shortly...

_{Preview built by GitHub Actions}

github-actions · 2025-12-02T10:59:26Z

🔨 Preview Build Complete!

Your changes have been built and pushed to GitHub Container Registry.

🐳 Docker Image: ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2339-79c03c0

📦 Download & Test Locally:

📁 Download Docker Image Artifact (look for wrongsecrets-preview-pr-2339)
Load and run the image:

# Download the artifact, extract it, then:
docker load < wrongsecrets-preview.tar
docker run -p 8080:8080 wrongsecrets-preview

🚀 Alternative - Pull from Registry:

docker pull ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2339-79c03c0
docker run -p 8080:8080 ghcr.io/owasp/wrongsecrets/wrongsecrets-pr:pr-2339-79c03c0

Then visit: http://localhost:8080

📝 Changes in this PR:
- src/main/resources/templates/welcome.html

Visual diff screenshots will be available shortly...

_{Preview built by GitHub Actions}

github-actions · 2025-12-02T11:00:23Z

📸 Visual Diff Ready!

Screenshots comparing your changes with the main branch are available:

📁 Download Visual Diff Artifacts

🖼️ Included screenshots:

pr-home.png vs main-home.png - Welcome page comparison
pr-about.png vs main-about.png - About page comparison
pr-challenge.png vs main-challenge.png - Challenge page comparison

🔍 How to review:

Download the artifact zip file
Extract and compare the pr-* and main-* images side by side
Look for visual differences in layout, styling, and content

💡 Tip: Use an image comparison tool or open both images in separate browser tabs to spot differences easily.

_{Visual diff generated by GitHub Actions • PR #2339}

github-actions · 2025-12-02T11:02:21Z

📸 Visual Diff Ready!

Screenshots comparing your changes with the main branch are available:

📁 Download Visual Diff Artifacts

🖼️ Included screenshots:

pr-home.png vs main-home.png - Welcome page comparison
pr-about.png vs main-about.png - About page comparison
pr-challenge.png vs main-challenge.png - Challenge page comparison

🔍 How to review:

Download the artifact zip file
Extract and compare the pr-* and main-* images side by side
Look for visual differences in layout, styling, and content

💡 Tip: Use an image comparison tool or open both images in separate browser tabs to spot differences easily.

_{Visual diff generated by GitHub Actions • PR #2339}

github-actions · 2025-12-08T08:02:55Z

🧹 Preview Cleanup Complete

The static preview for this PR has been removed from GitHub Pages.

Thanks for contributing to WrongSecrets! 🎉

_{Cleanup completed by GitHub Actions}

Initial plan

2b055c8

Copilot AI assigned Copilot and commjoen Dec 2, 2025

Copilot started work on behalf of commjoen December 2, 2025 08:58 View session

Copilot AI and others added 4 commits December 2, 2025 09:01

Initial plan for fixing dead link checker

cf76523

Co-authored-by: commjoen <[email protected]>

Fix incorrect GitHub URLs (www.github.com → github.com)

c5b7eba

Co-authored-by: commjoen <[email protected]>

Fix remaining www.github.com URL in LinkedIn share link

bdff1e3

Co-authored-by: commjoen <[email protected]>

Fix all remaining www.github.com URLs in README.md contributors section

a5f7e39

Co-authored-by: commjoen <[email protected]>

Copilot AI changed the title ~~[WIP] Fix failure in dead link checker~~ Fix dead link checker: correct www.github.com URLs Dec 2, 2025

Copilot AI requested a review from commjoen December 2, 2025 09:11

Copilot finished work on behalf of commjoen December 2, 2025 09:11

Copilot AI temporarily deployed to github-pages December 2, 2025 09:22 Inactive

Copilot started work on behalf of commjoen December 2, 2025 09:24 View session

Add pattern to exclude internal relative paths from link checker

5cc4677

Co-authored-by: commjoen <[email protected]>

Copilot AI changed the title ~~Fix dead link checker: correct www.github.com URLs~~ Fix dead link checker: correct www.github.com URLs and exclude internal routes Dec 2, 2025

Copilot finished work on behalf of commjoen December 2, 2025 09:27

Copilot AI had a problem deploying to github-pages December 2, 2025 10:51 Error

Copilot AI deployed to github-pages December 2, 2025 10:51 View deployment

commjoen closed this Dec 8, 2025

commjoen temporarily deployed to github-pages December 8, 2025 08:02 — with GitHub Actions Inactive

Uh oh!

Fix dead link checker: correct www.github.com URLs and exclude internal routes #2339

Fix dead link checker: correct www.github.com URLs and exclude internal routes #2339

Uh oh!

Conversation

Copilot AI commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What kind of changes does this PR include?

Description

Relations

References

Checklist:

Comments on the Issue (you are @copilot in this section)

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

commjoen commented Dec 2, 2025

Summary

Uh oh!

Copilot AI commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 2, 2025 •

edited

Loading