Skip to content

test(wallet-core): cover the credit-asset branch of sign_payment #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Emmyt24 merged 1 commit into from
Jul 19, 2026
Merged

test(wallet-core): cover the credit-asset branch of sign_payment #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 111 additions & 9 deletions crates/wallet-core/src/signer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,108 @@ mod tests {
assert!(!signed.envelope_xdr.is_empty());
}

// ── Credit-asset branch of sign_payment (#42) ────────────────────────────

#[test]
fn signs_credit_asset_payment_alphanum4() {
let (mk, sealed) = sealed_vector_seed(StellarNetwork::Testnet);
// USDC is 4 chars → AlphaNum4; use DEST as the issuer (a valid G... address).
let req = PaymentRequest {
destination: DEST,
stroops: 10_000_000,
asset: Some(("USDC", DEST)),
memo_id: None,
sequence: 1,
};
let signed = sign_payment(&mk, &sealed, StellarNetwork::Testnet, 0, &req).unwrap();
let env =
stellar_base::xdr::TransactionEnvelope::from_xdr_base64(&signed.envelope_xdr).unwrap();
match env {
stellar_base::xdr::TransactionEnvelope::Tx(e) => {
match &e.tx.operations[0].body {
stellar_base::xdr::OperationBody::Payment(pay) => {
assert!(
matches!(pay.asset, stellar_base::xdr::Asset::CreditAlphanum4(_)),
"4-char code must produce CreditAlphanum4 asset"
);
}
_ => panic!("expected Payment operation"),
}
}
_ => panic!("expected Tx envelope"),
}
}

#[test]
fn signs_credit_asset_payment_alphanum12() {
let (mk, sealed) = sealed_vector_seed(StellarNetwork::Testnet);
// "LONGTOKEN" is 9 chars (5-12 range) → AlphaNum12.
let req = PaymentRequest {
destination: DEST,
stroops: 10_000_000,
asset: Some(("LONGTOKEN", DEST)),
memo_id: None,
sequence: 1,
};
let signed = sign_payment(&mk, &sealed, StellarNetwork::Testnet, 0, &req).unwrap();
let env =
stellar_base::xdr::TransactionEnvelope::from_xdr_base64(&signed.envelope_xdr).unwrap();
match env {
stellar_base::xdr::TransactionEnvelope::Tx(e) => {
match &e.tx.operations[0].body {
stellar_base::xdr::OperationBody::Payment(pay) => {
assert!(
matches!(pay.asset, stellar_base::xdr::Asset::CreditAlphanum12(_)),
"9-char code must produce CreditAlphanum12 asset"
);
}
_ => panic!("expected Payment operation"),
}
}
_ => panic!("expected Tx envelope"),
}
}

#[test]
fn rejects_credit_asset_with_invalid_issuer() {
let (mk, sealed) = sealed_vector_seed(StellarNetwork::Testnet);
let req = PaymentRequest {
destination: DEST,
stroops: 1,
asset: Some(("USDC", "not-a-valid-G-address")),
memo_id: None,
sequence: 1,
};
assert!(matches!(
sign_payment(&mk, &sealed, StellarNetwork::Testnet, 0, &req),
Err(WalletError::InvalidAddress)
));
}

#[test]
fn rejects_credit_asset_with_invalid_code() {
let (mk, sealed) = sealed_vector_seed(StellarNetwork::Testnet);
// Empty string and a 13-char code are both outside the 1-12 byte range
// that Asset::new_credit accepts, so both must map to WalletError::InvalidAddress.
for bad_code in ["", "TOOLONGASSET1X"] {
let req = PaymentRequest {
destination: DEST,
stroops: 1,
asset: Some((bad_code, DEST)),
memo_id: None,
sequence: 1,
};
assert!(
matches!(
sign_payment(&mk, &sealed, StellarNetwork::Testnet, 0, &req),
Err(WalletError::InvalidAddress)
),
"code {:?} should be rejected",
bad_code
);
}
}

// ── Helper: build a signed inner payment envelope XDR ────────────────────

fn make_inner_xdr(source_index: u32, seq: i64) -> String {
Expand Down Expand Up @@ -590,7 +692,7 @@ mod tests {
&sealed,
StellarNetwork::Testnet,
0,
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200, sequence: 0 },
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200 },
)
.unwrap();

Expand Down Expand Up @@ -631,7 +733,7 @@ mod tests {
&sealed,
StellarNetwork::Testnet,
0,
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200, sequence: 0 },
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200 },
)
.unwrap();

Expand All @@ -658,7 +760,7 @@ mod tests {
&sealed,
StellarNetwork::Testnet,
0,
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200, sequence: 0 },
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200 },
)
.unwrap();

Expand All @@ -682,7 +784,7 @@ mod tests {
&sealed,
StellarNetwork::Testnet,
0,
&FeeBumpRequest { inner_xdr: "", max_base_fee_stroops: 200, sequence: 0 },
&FeeBumpRequest { inner_xdr: "", max_base_fee_stroops: 200 },
),
Err(WalletError::InvalidXdr)
));
Expand All @@ -701,7 +803,7 @@ mod tests {
&sealed,
StellarNetwork::Testnet,
0,
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200, sequence: 0 },
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200 },
)
.unwrap()
.envelope_xdr;
Expand All @@ -713,7 +815,7 @@ mod tests {
&sealed,
StellarNetwork::Testnet,
0,
&FeeBumpRequest { inner_xdr: &fee_bump_xdr, max_base_fee_stroops: 200, sequence: 0 },
&FeeBumpRequest { inner_xdr: &fee_bump_xdr, max_base_fee_stroops: 200 },
),
Err(WalletError::InvalidXdr)
));
Expand All @@ -731,7 +833,7 @@ mod tests {
&mainnet_sealed,
StellarNetwork::Testnet,
0,
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200, sequence: 0 },
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200 },
),
Err(WalletError::SeedDecryption)
));
Expand All @@ -750,7 +852,7 @@ mod tests {
&sealed,
StellarNetwork::Testnet,
0,
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: max_base_fee, sequence: 0 },
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: max_base_fee },
)
.unwrap();

Expand All @@ -776,7 +878,7 @@ mod tests {
&sealed,
StellarNetwork::Testnet,
0,
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200, sequence: 0 },
&FeeBumpRequest { inner_xdr: &inner_xdr, max_base_fee_stroops: 200 },
);
assert!(result.is_ok());
assert_eq!(result.unwrap().source_account, MASTER_ACCOUNT_0);
Expand Down
Loading