Skip to content

Add Atlas Cloud LLM provider preset - #844

Merged
H-Chris233 merged 2 commits into
Open-Less:betafrom
binyangzhu000-sudo:codex/add-atlascloud-llm-preset
Jul 21, 2026
Merged

Add Atlas Cloud LLM provider preset#844
H-Chris233 merged 2 commits into
Open-Less:betafrom
binyangzhu000-sudo:codex/add-atlascloud-llm-preset

Conversation

@binyangzhu000-sudo

@binyangzhu000-sudo binyangzhu000-sudo commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

User description

Summary

  • add Atlas Cloud to the existing LLM provider presets in settings
  • prefill the OpenAI-compatible base URL and Qwen3.5 Flash model placeholder while keeping the API key user-provided
  • add localized provider labels and a focused preset regression test

Validation

  • npx tsx src/pages/settings/ProvidersSection.test.ts
  • npm run build
  • git diff --check
  • Atlas live catalog returned qwen/qwen3.5-flash and deepseek-ai/deepseek-v4-pro

README: no README changes; no sponsor/logo/credits/partner promotion.


PR Type

Enhancement, Tests


Description

  • Add Atlas Cloud LLM provider preset

  • Add localization labels for Atlas Cloud across multiple languages

  • Add backend endpoint and frontend mapping for Atlas Cloud

  • Add regression test for Atlas Cloud preset configuration


Diagram Walkthrough

flowchart LR
  A["ProvidersSection.tsx"] --> B["LLM_PRESETS add atlascloud"]
  A --> C["ProvidersSection.test.ts"]
  B --> D["i18n localization files"]
  B --> E["Overview.tsx mapping"]
  E --> F["credentials.rs endpoint"]
Loading

File Walkthrough

Relevant files
Enhancement
3 files
credentials.rs
Add Atlas Cloud endpoint                                                                 
+1/-0     
Overview.tsx
Add atlascloud mapping to LLM name key                                     
+1/-0     
ProvidersSection.tsx
Add Atlas Cloud preset configuration and export                   
+7/-1     
Tests
2 files
mod.rs
Add test for Atlas Cloud API key requirement                         
+16/-0   
ProvidersSection.test.ts
Add regression test for Atlas Cloud preset                             
+15/-0   
Localization
5 files
en.ts
Add English label for Atlas Cloud                                               
+1/-0     
ja.ts
Add Japanese label for Atlas Cloud                                             
+1/-0     
ko.ts
Add Korean label for Atlas Cloud                                                 
+1/-0     
zh-CN.ts
Add Chinese (Simplified) label for Atlas Cloud                     
+1/-0     
zh-TW.ts
Add Chinese (Traditional) label for Atlas Cloud                   
+1/-0     

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 4612a12)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Potential Bug in Test

The test credentials_status_requires_api_key_for_atlascloud sets ark_endpoint and ark_model_id fields on the CredentialsSnapshot (lines 572-573) but then calls llm_configured_for_provider("atlascloud", &keyless). This appears to use the wrong credential fields for the 'atlascloud' provider, likely relying on ark-specific fields instead of atlascloud-specific fields. Unless the codebase intentionally reuses ark fields for atlascloud (unlikely and confusing), this test will not correctly validate atlascloud provider configuration. The test should set atlascloud-specific fields (e.g., atlascloud_endpoint, atlascloud_api_key) for the provider to be properly tested.

fn credentials_status_requires_api_key_for_atlascloud() {
    let keyless = CredentialsSnapshot {
        ark_endpoint: Some("https://api.atlascloud.ai/v1".into()),
        ark_model_id: Some("qwen/qwen3.5-flash".into()),
        ..snapshot()
    };
    assert!(!llm_configured_for_provider("atlascloud", &keyless));

    let ready = CredentialsSnapshot {
        ark_api_key: Some("key".into()),
        ..keyless
    };
    assert!(llm_configured_for_provider("atlascloud", &ready));
}

@H-Chris233 H-Chris233 self-assigned this Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 4612a12

@H-Chris233
H-Chris233 merged commit ef66246 into Open-Less:beta Jul 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants