chore(deps): bump chokidar from 4.0.3 to 5.0.0#153
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Bumps [chokidar](https://github.com/paulmillr/chokidar) from 4.0.3 to 5.0.0. - [Release notes](https://github.com/paulmillr/chokidar/releases) - [Commits](paulmillr/chokidar@4.0.3...5.0.0) --- updated-dependencies: - dependency-name: chokidar dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
eb64399 to
19d06b0
Compare
There was a problem hiding this comment.
Findings
- [Blocker]
chokidar5 will break the Electron main-process startup path.package.json:78upgrades to an ESM-only major, but the main-process build still externalizeschokidarin the "CJS-compatible" dependency list (vite.config.ts:37-45).SkillsManagerimports it at module load (src/main/skills/skills-manager.ts:17), andsrc/main/index.ts:22eagerly importsSkillsManager, so this can fail before the app window opens.
Suggested fix:"chokidar": "^4.0.1"
Summary
Review mode: initial
- 1 blocker found:
chokidarv5 is incompatible with the current Electron main-process bundling strategy (package.json:78,vite.config.ts:37-45). - Residual risk: I did not find test coverage in
src/tests/for packaged main-process startup or theSkillsManagerwatcher path.
Testing
- Not run (automation). Suggested coverage: a startup smoke test that exercises the Electron main process with
watchStorage: trueenabled.
Open Cowork Bot
| "archiver": "^7.0.1", | ||
| "better-sqlite3": "^12.8.0", | ||
| "chokidar": "^4.0.1", | ||
| "chokidar": "^5.0.0", |
There was a problem hiding this comment.
[BLOCKER] chokidar 5 is not safe here yet. This repo still externalizes chokidar from the Electron main bundle in a section explicitly reserved for CJS-compatible deps (vite.config.ts:37-45), while SkillsManager imports it at module load (src/main/skills/skills-manager.ts:17) and src/main/index.ts:22 eagerly imports SkillsManager. That makes the ESM-only major bump likely to fail on app startup, not just when the watcher is first used.
Suggested fix:
"chokidar": "^4.0.1"If you want to adopt v5, first stop externalizing chokidar in vite.config.ts and verify the packaged main-process startup path.
Bumps chokidar from 4.0.3 to 5.0.0.
Release notes
Sourced from chokidar's releases.
Commits
c0c8d20Release 5.0.0.b211cecRemove src from npm8742246Upgrade dev deps, jsbt, ci files. Upgrade readdirp to v5.de5a34cMerge pull request #1442 from paulmillr/flaky-bunsc08a6c4fix: throttle based on dir + target0c55ab3test: wait for explicit calls in directory testce81be5perf: re-use double slash regex (#1435)7d9c1edMerge pull request #1433 from paulmillr/super-matrices3915541Merge pull request #1430 from paulmillr/esm-only9308bedchore: use Nodejs 24 in CI (#1432)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for chokidar since your current version.