Skip to content

chore(deps): bump chokidar from 4.0.3 to 5.0.0#153

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/chokidar-5.0.0
Open

chore(deps): bump chokidar from 4.0.3 to 5.0.0#153
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/chokidar-5.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Apr 18, 2026

Copy link
Copy Markdown
Contributor

Bumps chokidar from 4.0.3 to 5.0.0.

Release notes

Sourced from chokidar's releases.

5.0.0

  • Make the package ESM-only. Reduces on-disk package size from ~150kb to ~80kb
  • Increase minimum node.js version to v20.19. The versions starting from it support loading esm files from cjs
  • fix: Make types more precise paulmillr/chokidar#1424
  • perf: re-use double slash regex paulmillr/chokidar#1435
  • Update readdirp to ESM-only v5
  • Lots of minor improvements in tests
  • Increase security of NPM releases. Switch to token-less Trusted Publishing, with help of jsbt
  • Switch compilation mode to isolatedDeclaration-based typescript for simplified auto-generated docs

New Contributors

Full Changelog: paulmillr/chokidar@4.0.3...5.0.0

Commits
Maintainer changes

This version was pushed to npm by GitHub Actions, a new releaser for chokidar since your current version.


Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot @github

dependabot Bot commented on behalf of github Apr 18, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies. Please create it before Dependabot can add it to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

Bumps [chokidar](https://github.com/paulmillr/chokidar) from 4.0.3 to 5.0.0.
- [Release notes](https://github.com/paulmillr/chokidar/releases)
- [Commits](paulmillr/chokidar@4.0.3...5.0.0)

---
updated-dependencies:
- dependency-name: chokidar
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/chokidar-5.0.0 branch from eb64399 to 19d06b0 Compare April 22, 2026 07:56
@hqhq1025 hqhq1025 added bot-rerun Temporary label for rerunning bot automation and removed bot-rerun Temporary label for rerunning bot automation labels Apr 30, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • [Blocker] chokidar 5 will break the Electron main-process startup path. package.json:78 upgrades to an ESM-only major, but the main-process build still externalizes chokidar in the "CJS-compatible" dependency list (vite.config.ts:37-45). SkillsManager imports it at module load (src/main/skills/skills-manager.ts:17), and src/main/index.ts:22 eagerly imports SkillsManager, so this can fail before the app window opens.
    Suggested fix:
    "chokidar": "^4.0.1"

Summary

Review mode: initial

  • 1 blocker found: chokidar v5 is incompatible with the current Electron main-process bundling strategy (package.json:78, vite.config.ts:37-45).
  • Residual risk: I did not find test coverage in src/tests/ for packaged main-process startup or the SkillsManager watcher path.

Testing

  • Not run (automation). Suggested coverage: a startup smoke test that exercises the Electron main process with watchStorage: true enabled.

Open Cowork Bot

Comment thread package.json
"archiver": "^7.0.1",
"better-sqlite3": "^12.8.0",
"chokidar": "^4.0.1",
"chokidar": "^5.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BLOCKER] chokidar 5 is not safe here yet. This repo still externalizes chokidar from the Electron main bundle in a section explicitly reserved for CJS-compatible deps (vite.config.ts:37-45), while SkillsManager imports it at module load (src/main/skills/skills-manager.ts:17) and src/main/index.ts:22 eagerly imports SkillsManager. That makes the ESM-only major bump likely to fail on app startup, not just when the watcher is first used.

Suggested fix:

"chokidar": "^4.0.1"

If you want to adopt v5, first stop externalizing chokidar in vite.config.ts and verify the packaged main-process startup path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant