Type c service direct async calls#833
Draft
RobertZ2011 wants to merge 15 commits into
Draft
Conversation
Move the `Controller` trait into its own module, and create a dedicated module for types used as arguments/return values for various PD functions.
The `Controller` trait is meant to abstract over PD controller hardware. However, the current implementation exposes the underlying bus error type. This isn't particulary useful, leaks implementation details, and makes code more complicated when using enum dispatch. Remove it. Implementators of this trait should log bus-specific error information and return a `PdError`.
Break-up this trait to make everything more modular.
The LPM command contains the port number. Combine controller and port ucsi traits.
This information is too hardware specific to expose it in a trait.
Transitioning away from the last bit of messaging code, no longer needed.
RobertZ2011
force-pushed
the
type-c-service-direct-async-calls
branch
from
0e41390 to
39cc831
Compare
Any device should have a human readable name.
Remove most uses of this type, limited it mostly to the UCSI code. Service events now deal directly with referencs to port objects. Remove port state stored in service implementation.
Cargo Vet Audit Passed
|
RobertZ2011
force-pushed
the
type-c-service-direct-async-calls
branch
from
8ed3fc8 to
de3f1b1
Compare
RobertZ2011
force-pushed
the
type-c-service-direct-async-calls
branch
from
de3f1b1 to
352e330
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.