fix(evse.keba): apply SCALE_FACTOR_1 to Keba energy limit register - #3863
Open
sankalpsthakur wants to merge 6 commits into
Open
fix(evse.keba): apply SCALE_FACTOR_1 to Keba energy limit register#3863sankalpsthakur wants to merge 6 commits into
sankalpsthakur wants to merge 6 commits into
Conversation
Register 5010 (SET_ENERGY_LIMIT) is documented in units of 10 Wh, but the write task mapped it with no converter, so a channel value of 1000 Wh was written as raw 1000 instead of 100 - a 10x error. SCALE_FACTOR_1 is the same converter already used elsewhere in this class for 10 Wh-scaled registers; no new converter is needed. Fixes OpenEMS#3765
Contributor
|
Thank you. Could you please fix the same issue also in |
sfeilmeier
self-requested a review
August 2, 2026 19:40
Author
Applied the same The PR is mergeable and CI is waiting for maintainer authorization. Ready for re-review. |
sankalpsthakur
commented
Aug 5, 2026
Author
|
Hi @sfeilmeier, verified both fixes and tests are present on 7f6e748. Ready for re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Keba EVSE energy-limit register (5010,
SET_ENERGY_LIMIT) is documented in units of 10 Wh, but the write task mapped it with no scale converter — matching the// TODO Scalefactor for Unit: 10 Whcomment already left in the code at that exact line. As a result, setting a 1000 Wh energy limit wrote raw register value1000instead of100, a 10x error.SCALE_FACTOR_1is already used elsewhere in this class for other 10 Wh-scaled registers, so no new converter is needed — this applies the existing one to register 5010 and removes the now-resolved TODO.Validation
develop.ElementToChannelConverter's documented behavior:SCALE_FACTOR_1converts raw register value1to channel value10(and the inverse on write), which is exactly the 10 Wh scaling the register requires.Fixes #3765
AI/LLM disclosure