This repository was archived by the owner on Dec 31, 2024. It is now read-only.
Add support for Enum<?> as Feign client parameters for multipart payload#76
Open
reta wants to merge 1 commit intoOpenFeign:masterfrom
Open
Add support for Enum<?> as Feign client parameters for multipart payload#76reta wants to merge 1 commit intoOpenFeign:masterfrom
reta wants to merge 1 commit intoOpenFeign:masterfrom
Conversation
Author
|
Sorry @xxlabaza, may you take a look please? Thank a lot :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
We've run into an issue recently when multipart endpoint uses Java's enumeration (
Enum<?>) for some of the parameter. TheMultipartFormContentProcessordoes recognize theEnumas the POJO and tries to convert it into theMap, ending up with the empty one. As such, allEnum<?>parameters are not being included into the request.The fix is simple (add
EnumWriter), the test cases is provided, easy to reproduce.Thank you.
Best Regards,
Andriy Redko