Fix branding in JNLP#284
Merged
Merged
Conversation
mgaffigan
marked this pull request as ready for review
April 4, 2026 04:25
tonygermano
reviewed
Apr 4, 2026
tonygermano
previously approved these changes
Jun 28, 2026
Closed
kpalang
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1 and
ssrowe
July 1, 2026 08:04
kpalang
previously approved these changes
Jul 1, 2026
kpalang
left a comment
kpalang
left a comment
Contributor
There was a problem hiding this comment.
Review comments formatted as conventional comments.
NicoPiel
previously approved these changes
Jul 2, 2026
kryskool
approved these changes
Jul 14, 2026
tonygermano
dismissed stale reviews from NicoPiel, kpalang, and themself
via
July 14, 2026 20:33
29bbeac
tonygermano
force-pushed
the
branding-jnlp
branch
from
July 14, 2026 20:33
1fcaf13 to
29bbeac
Compare
tonygermano
approved these changes
Jul 14, 2026
tonygermano
left a comment
tonygermano
left a comment
Member
There was a problem hiding this comment.
reapproving after rebase with merge conflict
Member
|
Conflict was due to 49b5884 |
JNLP still references MirthConnect, which theoretically controls the icon and name. Images do not exist. current launchers do not use it, but we should have it correct anyway. Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
tonygermano
force-pushed
the
branding-jnlp
branch
from
July 14, 2026 22:36
29bbeac to
a08c114
Compare
NicoPiel
approved these changes
Jul 15, 2026
kryskool
approved these changes
Jul 15, 2026
kpalang
self-requested a review
July 15, 2026 07:04
kpalang
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JNLP still references MirthConnect, which theoretically controls the icon and name. Images do not exist. current launchers do not use it, but we should have it correct anyway.