feat: Update to use Pydantic V2 and enable chunking#134
Merged
mwiebe merged 1 commit intoOpenJobDescription:mainlinefrom Feb 26, 2025
Merged
feat: Update to use Pydantic V2 and enable chunking#134mwiebe merged 1 commit intoOpenJobDescription:mainlinefrom
mwiebe merged 1 commit intoOpenJobDescription:mainlinefrom
Conversation
epmog
reviewed
Feb 11, 2025
Contributor
epmog
left a comment
epmog
left a comment
There was a problem hiding this comment.
LGTM. Once the new model version is released we can update the PR.
I'd bias towards not a breaking change for this since it's an application that isn't changing as opposed to the library usage. But I won't die on that hill.
mwiebe
changed the title
mwiebe
changed the title
mwiebe
force-pushed
the
pydantic2
branch
2 times, most recently
from
67b2c8e to
c465a27
Compare
Signed-off-by: Mark Wiebe <399551+mwiebe@users.noreply.github.com>
|
epmog
approved these changes
Feb 26, 2025
moorec-aws
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The CLI depends on some implementation details of Pydantic V1 that have changed in V2. Need to update to match OpenJobDescription/openjd-model-for-python#164.
What was the solution? (How)
Modify the code to work with the Pydantic V2 openjd-model.
What is the impact of this change?
The CLI will continue to work after the Pydantic V2 upgrade
How was this change tested?
Yes
Was this change documented?
N/A
Is this a breaking change?
No, nothing about the CLI interface is changing.
This is an update to match a breaking change in the openjd-model library. That change is breaking because its interface is based on Pydantic, so code that depends on details that differ in V2 need to be updated.
Does this change impact security?
No security impacts.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.