feat: Implement FEATURE_BUNDLE_1 RFC 0004#204
feat: Implement FEATURE_BUNDLE_1 RFC 0004#204mwiebe merged 1 commit intoOpenJobDescription:mainlinefrom
Conversation
mwiebe
force-pushed
the
implement-rfc-0004
branch
from
10c3e92 to
f014ee2
Compare
| """Test that format string timeout is resolved.""" | ||
| template = TEMPLATES_DIR / "feature_bundle_1_timeout.yaml" | ||
| outerr = run_openjd_cli_main(capsys, args=["run", str(template)], expected_exit_code=0) | ||
| assert "Running with timeout 5s" in outerr.out |
There was a problem hiding this comment.
This works, but I think it feels more "correct" to have the test ensure the task actually times out, so we know for sure OpenJD is using the parametrized timeout property to set the task timeout.
There was a problem hiding this comment.
It's a nice idea, but it would also make the tests slower. This may be something to test in openjd-sessions instead?
mwiebe
force-pushed
the
implement-rfc-0004
branch
2 times, most recently
from
6465051 to
a0060e6
Compare
mwiebe
force-pushed
the
implement-rfc-0004
branch
3 times, most recently
from
c36da06 to
a13c070
Compare
stangch
left a comment
stangch
left a comment
There was a problem hiding this comment.
I noticed there were Min and Max Properties in <AmountRequirement> in the RFC 0004, but I'm unsure if that is reflected here/ needs tests for?
mwiebe
force-pushed
the
implement-rfc-0004
branch
from
a13c070 to
85573e5
Compare
I had started these as more of a spot check, but yeah it's nice to make them more complete. I've added min/max/notifyPeriod test templates. |
Signed-off-by: Mark <399551+mwiebe@users.noreply.github.com>
mwiebe
force-pushed
the
implement-rfc-0004
branch
from
85573e5 to
9b5baff
Compare
|
4 participants
What was the problem/requirement? (What/Why)
When OpenJobDescription/openjd-model-for-python#258 and OpenJobDescription/openjd-sessions-for-python#299 are merged, this library is next.
What was the solution? (How)
Add FEATURE_BUNDLE_1 to the accepted extension list, and add tests of some of the functionality.
What is the impact of this change?
Support for OpenJD RFC 0004.
How was this change tested?
Tested together with the openjd-model and an openjd-sessions change.
Was this change documented?
N/A
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.