flx: handle None environments correctly#254
Merged
crowecawcaw merged 1 commit intoOpenJobDescription:mainlinefrom Dec 15, 2025
Merged
Conversation
Add type check in _validate_has_script_or_variables to raise a proper ValidationError when environment is None instead of AttributeError. Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
|
AWS-Samuel
approved these changes
Dec 15, 2025
baxeaz
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #252
What was the problem/requirement? (What/Why)
If a job template's environment was
None, the library threw an unexpected exception.What was the solution? (How)
Catch this error and raise a ValueError properly.
What is the impact of this change?
Prevents unexpected errors from this library
How was this change tested?
Unit test
Was this change documented?
n/a
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.