Skip to content

chore: Fix up comments and test code from PR feedback #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwiebe merged 1 commit into from
Feb 2, 2026
Merged

chore: Fix up comments and test code from PR feedback #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/openjd/model/v2023_09/_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,9 @@ class EmbeddedFileText(OpenJDModel_v2023_09):
will have its execute-permissions set.
Default: False
data (FormatString): The text data to write to the file.
endOfLine (Optional[EndOfLine]): Line ending style. Requires FEATURE_BUNDLE_1 extension.
endOfLine (Optional[EndOfLine]): The line endings that the embedded file will have when
written to disk. If AUTO the embedded file will have the default line endings of the
host operating system. Requires FEATURE_BUNDLE_1 extension.
Default: AUTO
"""

Expand Down
2 changes: 0 additions & 2 deletions test/openjd/model/test_parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,15 +194,13 @@ class MockExtensionName(str, Enum):
"""A mock enum with only SUPPORTED_NAME for testing."""

SUPPORTED_NAME = "SUPPORTED_NAME"
FEATURE_BUNDLE_1 = "FEATURE_BUNDLE_1"


class MockExtensionNameWithTwoNames(str, Enum):
"""A mock enum with only SUPPORTED_NAME for testing."""

SUPPORTED_NAME = "SUPPORTED_NAME"
ANOTHER_SUPPORTED_NAME = "ANOTHER_SUPPORTED_NAME"
FEATURE_BUNDLE_1 = "FEATURE_BUNDLE_1"


@pytest.mark.parametrize(
Expand Down
Loading