Move Aircraft.Fuselage.FORM_FACTOR to premission#1071
Open
xjjiang wants to merge 28 commits intoOpenMDAO:mainfrom
Open
Move Aircraft.Fuselage.FORM_FACTOR to premission#1071xjjiang wants to merge 28 commits intoOpenMDAO:mainfrom
xjjiang wants to merge 28 commits intoOpenMDAO:mainfrom
Conversation
…se it is set by set_params_for_unit_tests() already.
xjjiang
changed the title
| aircraft:fuselage:delta_diameter,4.5,ft | ||
| aircraft:fuselage:flat_plate_area_increment,0.25,ft**2 | ||
| aircraft:fuselage:form_factor,1.25,unitless | ||
| aircraft:fuselage:form_factor,1.05557953,unitless |
Member
There was a problem hiding this comment.
What did the fuselage form factor change in the csv file? I am guessing that the new value is the value we are calculating now, and the old value was never used because this couldn't be overriden.
In which case, we can probably just take this line out of these csv files, since it is being calculated.
Contributor
Author
There was a problem hiding this comment.
You are right. Now, I removed this line. There might be other lines that are not used in the models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FormFactorAndSIWBtoFormFactorandSIWB.BWBFormFactorAndSIWBtoBWBFormFactorandBWBSIWB.FormFactorandBWBFormFactorto premission.SIBWandBWBSIBWin mission. Theoretically,SIWBcan be moved to premission, but we would have to create an Aviary variable for it.Related Issues
Backwards incompatibilities
None
New Dependencies
None