Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates KiteControllers.jl’s test and example tooling to use MakieControlPlots instead of ControlPlots, aligning plotting across the repo and updating related environment/setup scripts.
Changes:
- Replaced
ControlPlotsimports/usages withMakieControlPlotsacross examples and manual test scripts, and updated example/test Project.toml dependencies. - Updated install/sysimage helper scripts and CI workflow filters to reference
MakieControlPlots. - Tightened a couple of internal state transition helpers by adding enum type annotations (
SystemState,FPPS).
Reviewed changes
Copilot reviewed 30 out of 37 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_wrap2pi.jl | Switch manual plotting import from ControlPlots to MakieControlPlots. |
| test/test_fpc_low_right.jl | Switch plotting import to MakieControlPlots (note: redundant using remains). |
| test/test_flightpathcontroller3.jl | Switch plotting import to MakieControlPlots. |
| test/test_flightpathcontroller2.jl | Switch plotting import to MakieControlPlots. |
| test/test_flightpathcontroller1.jl | Switch plotting import to MakieControlPlots. |
| test/Project.toml | Replace ControlPlots dependency/compat with MakieControlPlots. |
| test/create_sys_image.jl | Build test sysimage with MakieControlPlots instead of ControlPlots. |
| src/systemstatecontrol.jl | Type-annotate switch(..., state::SystemState) for stricter state transitions. |
| src/KiteControllers.jl | Update install_examples() to add MakieControlPlots. |
| src/flightpathplanner2.jl | Type-annotate _switch(..., state::FPPS) for stricter planner transitions. |
| Manifest-v1.12.toml.default | Update default manifest to reflect dependency changes (Makie stack, removal of ControlPlots stack). |
| examples/tune_4p.jl | Switch plotting import to MakieControlPlots; adjust figure closing call. |
| examples/tune_1p.jl | Switch plotting import to MakieControlPlots; adjust figure closing call. |
| examples/Project.toml | Remove ControlPlots and add MakieControlPlots dependency/compat. |
| examples/plots.jl | Replace ControlPlots.* calls with MakieControlPlots.*. |
| examples/plot_loading.jl | Switch to MakieControlPlots and make OUTPUT_DIR a const. |
| examples/parking_wind_dir.jl | Switch to MakieControlPlots; move FFMPEG_jll import to top; make flags const; tweak plot sizing. |
| examples/parking_4p.jl | Switch to MakieControlPlots; remove references to removed fields/old controller API; update steering call signature. |
| examples/parking_1p.jl | Switch to MakieControlPlots import. |
| examples/menu_learning.jl | Replace catch e with catch _ (unused exception binding). |
| examples/learn_corrections.jl | Switch to MakieControlPlots; remove unused global declaration block; update plotting calls. |
| examples/joystick.jl | Adjust joystick globals initialization to avoid const-in-conditional pattern. |
| examples/create_wind_fields.jl | Update env activation check to MakieControlPlots. |
| examples/batch_plot.jl | Switch to MakieControlPlots; replace blocking show with wait_for_figures(). |
| examples/batch_pilot.jl | Refactor project list into const DEFAULT_PROJECTS + projects() helper; small typing tweak. |
| examples/autopilot.jl | Switch to MakieControlPlots; move FFMPEG_jll import to top; make OUTPUT_DIR a const. |
| examples/autopilot_1p.jl | Update env activation check to MakieControlPlots. |
| examples/analyse.jl | Switch to MakieControlPlots and make OUTPUT_DIR a const. |
| bin/setup_env | Update comment to reference MakieControlPlots sysimage (was ControlPlots). |
| bin/jetls_examples | Add logging via tee to output log file (currently masks failures unless fixed). |
| bin/jetls | Add logging via tee to output log file (currently masks failures unless fixed). |
| bin/install_controlplots | Remove obsolete installer script for ControlPlots/matplotlib backend setup. |
| bin/install | Replace ControlPlots checks/usages with MakieControlPlots; simplify platform-specific plotting setup logic. |
| bin/create_sys_image | Switch test sysimage load-check from ControlPlots to MakieControlPlots. |
| .JETLSConfig.toml.default | Adjust diagnostics config; disable type inlay hints. |
| .gitignore | Ignore output/ broadly (but includes an accidental timestamp-specific log entry). |
| .github/workflows/CI.yml | Update “remove plotting packages” filters to drop MakieControlPlots instead of ControlPlots. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.