Fix warnings - #232
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses warnings related to unused parameters/closure arguments in the YAML loading code path.
Changes:
- Renames unused
load_wingparameters to underscore-prefixed names to indicate intentional non-use. - Renames unused lambda parameters in YAML constructor mappings to underscore-prefixed names.
- Adds
data/catenary_export.yamlto.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/yaml_loader.jl | Marks intentionally-unused arguments (function + mapping lambdas) with underscore-prefixed names to avoid unused-parameter warnings. |
| .gitignore | Ignores a specific generated YAML artifact (data/catenary_export.yaml). |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Instead of renaming the unused parameters to function load_wing(mode::AbstractAeroModel, row, idx, ::Any, set, wing_type,
vsm_set, yaml_to_ref, yaml_parse_ref_points,
yaml_parse_origin, ::Any)These two positional slots only exist so this method's signature matches the For the mapping closures that ignore their argument ( :set => _ -> set,
:vsm_set => _ -> vsm_set,
If the |
|
outdated |
Fix warnings about unused parameters