Unify RamAirWing and Wing into Wing - #204
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…3_kite example to resemble wind tunnel test in alpha and beta and input data and comparison data, and added a center of pressure calculation method
Replace LinearAlgebra norm/dot/normalize\!/cross with inline scalar helpers (norm3, dot3, normalize3\!, cross3\!) across hot paths. Unroll heterogeneous filament loop to eliminate Union dispatch. Fix tuple slicing, matrix slice copies, and broadcast allocations. AIC: 4010 → 10 allocs, gamma_loop: 9 → 0, calculate_results: 857 → 590, solve_base\!/solve\!: broken → passing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…' into wing_groups_unify_wing
1-Bart-1
added a commit
that referenced
this pull request
Jul 1, 2026
* Make sure 0 groups works * Unify Wing and RamAirWing * Restore test * Not passing bench * Working grouping * Working tests except aqua * Working tests with aqua * Don't deform tuple * Option to not use data prefix * Add obj set * Old tests not failing * Passing tests * Add cl cd cm group array * Added tests and settings * Improved obj file reading * Fixed deform * Test on 1.10 and 1.11 * Disable mapping kwarg * Add kwarg to sort sections * Add groups * Correct width * Add makie plotting * Don't use corrected alpha * Updated settings * Use plot and plot! with obs * Use unrefined sections * Use glmakie * Use unrefined segments and no groups * Working ram example * Add combined plot * Dont use old vsm * Actually remove super confusing unrefined panels, simplify to use unrefined segments everywhere * Adjust for using the unrefined segment approach * Dist for per panel, unrefined_dist for per unrefined section * Update the deform functions to make more sense * Update tests for recent changes * Rename to more logical name * Add claude md * Rename * Simpler example, angle at wingtips * Add unreleased news * Remove last instances of groups * Removed groups * Add tests for smoothing and non smoothing deform * Add everything plotting function * Manual refine * Improved makie plotting * Deformable yaml kite * Fix for updated separate refine * Move Obj to refinement method * Add obj wing refinement test * Auto refine yaml wing * Width is sum not average * adjusted V3_kite example, added literature plotting to MakieExt, changed alpha_geometric to angle between va and chord, changed settings_jl to default the corrected_aoa to false * added alpha_geometric_dist to the solver output, and updated example V3_kite to also test solve! output * Add option to disable sort * Flat extrapolate * Extrapolate lift flat drag line * Update news * Update recursive array tools * Update prealloc tools * Update docs * Fix date * Unreleased news * Add setup test * Use makie * Add prefixes * Use makie * Add setup test * Simplify install examples * No wait if not interactive * Dont show * Implement claude review * No pycall * Dont update yet * Headless lets go * corrected moment and handling of nonuniform inflow, also update the v3_kite example to resemble wind tunnel test in alpha and beta and input data and comparison data, and added a center of pressure calculation method * No eval * Fix allocation regressions on Julia 1.12 Replace LinearAlgebra norm/dot/normalize\!/cross with inline scalar helpers (norm3, dot3, normalize3\!, cross3\!) across hot paths. Unroll heterogeneous filament loop to eliminate Union dispatch. Fix tuple slicing, matrix slice copies, and broadcast allocations. AIC: 4010 → 10 allocs, gamma_loop: 9 → 0, calculate_results: 857 → 590, solve_base\!/solve\!: broken → passing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add sandbox files to gitignore * Add some overhead * Use headless makie * Julia lts and latest * Restore surfplan * adding figure to readme * add use_prior_polar functionality * Add controlplots tests * Make less restrictive * Improve plotting dispatch * Use julia-runtest --------- Co-authored-by: jellepoland <jellepoland@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.