Skip to content

fix: Make sure decidim cookies banner doesn't appear #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moustachu merged 4 commits into from
May 22, 2026
+7 −2
Merged

fix: Make sure decidim cookies banner doesn't appear #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c51f83
fix: Make sure decidim cookies banner doesn't appear
AyakorK Apr 16, 2026
fac9977
fix: remove cookies acceptance from test
AyakorK Apr 16, 2026
848dd85
Merge branch 'develop' into fix/cookies_banner
moustachu May 22, 2026
9164bd7
Merge branch 'develop' into fix/cookies_banner
moustachu May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/packs/stylesheets/decidim/global_adjustments.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,11 @@

.main-bar__links-desktop__item-wrapper div:has(a[aria-label="Activité"]) {
display: none;
}

#dc-dialog-wrapper.cookies__container,
#dc-modal,
a[data-dialog-open="dc-modal"],
li:has(a[data-dialog-open="dc-modal"]) {
display: none !important;
}
2 changes: 0 additions & 2 deletions spec/system/mobile_header_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
driven_by(:iphone)
switch_to_host(organization.host)
visit decidim.root_path
click_on(id: "dc-dialog-accept")
end

it "has a sticky header" do
Expand Down Expand Up @@ -79,7 +78,6 @@
switch_to_host(organization.host)
login_as user, scope: :user
visit decidim.root_path
click_on(id: "dc-dialog-accept")
end

it "displays an avatar on the header" do
Expand Down
Loading