Skip to content

Fix: editing responses on a survey#987

Merged
moustachu merged 4 commits into
rc-4.0.0from
fix/modify_response_on_survey
May 22, 2026
Merged

Fix: editing responses on a survey#987
moustachu merged 4 commits into
rc-4.0.0from
fix/modify_response_on_survey

Conversation

@Stef-Rousset
Copy link
Copy Markdown
Contributor

@Stef-Rousset Stef-Rousset commented May 15, 2026

🎩 Description

This PR updates the Gemfile.lock and package-lock.json to get the latest version of decidim that includes this backport decidim/decidim#16809 of the bug fix on editing responses for a survey.

This PR removes the override of FindAndUpdtaeDescendantsJob, because of the evolution of the code in 0.31 (notably 2 arguments instead of one in perfom method that causes error). The necessity of the override in 0.31 should be study in another card (cfhttps://github.com/orgs/OpenSourcePolitics/projects/26/views/1?pane=issue&itemId=186116483&issue=OpenSourcePolitics%7Cintern-tasks%7C443).

And eventually, it updates the proposals_index system test.

Testing

  1. As an admin, create a new survey, add 2 questions. Add a display condition on the question 2 depending on question one.
  2. In the settings, allow the users to modify their responses.
  3. As a user, answer the survey
  4. As a user, click on "Edit your responses"
  5. See that you have access to the edit page (cf screenshot)

📌 Related Issues

📷 Screenshots

591845802-60c31c54-bee3-4da5-969e-b40daa7ef60c

@Stef-Rousset Stef-Rousset changed the title Fix: get latest version of decidim to integrate correction Fix: get latest version of decidim to integrate bug fix May 15, 2026
@Stef-Rousset Stef-Rousset changed the title Fix: get latest version of decidim to integrate bug fix Fix: editin responses on a survey May 15, 2026
@Stef-Rousset Stef-Rousset changed the title Fix: editin responses on a survey Fix: editing responses on a survey May 15, 2026
@Stef-Rousset Stef-Rousset marked this pull request as ready for review May 15, 2026 11:43
@moustachu moustachu merged commit cf803c1 into rc-4.0.0 May 22, 2026
13 checks passed
@moustachu moustachu deleted the fix/modify_response_on_survey branch May 22, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants