ume: Add interpolation to rv64ume and custom template tags#834
ume: Add interpolation to rv64ume and custom template tags#834arcane-quill wants to merge 17 commits intomasterfrom
Conversation
|
I think the branch of this PR isn't cleanly based on a fresh master, because it contains some of my commits that are already on master. So let's rebase on master with (on your branch): There might be some conflicts but if you execute these commands in IntelliJ you'll get some help resolving the conflicts in a nice UI. 😉 |
I tried to rebase twice now but it doesnt seem to be fixed @flofriday |
|
Yeah sometimes rebasing still contains some weired artifacts, but I just tried it on my machine and it (mostly) worked. I'll send you a DM (on matrix), let's figure it out there. |
ce9eaf4 to
0d64625
Compare
2c3616b to
4d6afb8
Compare
7d8ab0a to
4d6afb8
Compare
4d6afb8 to
f54e597
Compare
4d6afb8 to
f54e597
Compare
Jozott00
left a comment
There was a problem hiding this comment.
Unfortunately the current state is too RISC-V specific and needs an overhaul. Please take a closer look at other VIAM definitions and how they are handled in the code emission.
|
|
||
| env->pc = regs->sepc; | ||
| env->x[RV64UME_REG_SP] = regs->sp; | ||
| env->[(${pc_reg.name_lower})] = regs->[(${config.ptRegPc})]; |
There was a problem hiding this comment.
What does ptRegPc stand for?
Thanks for the extensive review, I'm working on it now |
PR for issue #757 (and #761, #759)
interpolated hardcoded rv64ume files from linux-user
created UmeHardcodedRiscvDefinitionPass and UmeTemplateRenderingPass to add custom template tags (e.g. registers, exceptions..) with hardcoded values that later get filled in by the vadl file
added VIAM definition UserModeEmulation