Prevent OvEditor crash on unhandled sol::error after Lua runtime errors#801
Merged
Conversation
adriengivry
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a crash in OvEditor when a Lua runtime error triggers an unhandled
sol::errorduring behaviour callback execution.The Lua callback lookup/call path is now guarded to catch
sol::errorand log it instead of letting the exception propagate and terminate the editor.Scope is intentionally minimal:
LuaScriptEngine.cppRelated Issue(s)
Fixes #797
Review Guidance
Please focus on
ExecuteLuaFunction(...)in:Sources/OvCore/src/OvCore/Scripting/Lua/LuaScriptEngine.cppWhat changed:
try/catch (const sol::error&)Expected behavior after this change:
Screenshots/GIFs
N/A
AI Usage Disclosure
N/A
Checklist
When applicable, I have commented my code, particularly in hard-to-understand areasWhen applicable, I have updated the documentation accordingly