Skip to content

Fix hierarchy actor creation menu target resolution#803

Merged
adriengivry merged 1 commit into
Overload-Technologies:mainfrom
Gopmyc:799
May 11, 2026
Merged

Fix hierarchy actor creation menu target resolution#803
adriengivry merged 1 commit into
Overload-Technologies:mainfrom
Gopmyc:799

Conversation

@Gopmyc
Copy link
Copy Markdown
Contributor

@Gopmyc Gopmyc commented May 11, 2026

Description

This PR fixes the actor target used by the Hierarchy panel creation menu.

ActorCreationMenu::GenerateActorCreationMenu now receives m_targetActor directly instead of GetTargetActor(), ensuring the creation action consistently uses the current hierarchy target actor context.

Related Issue(s)

Fixes #799

Review Guidance

  • Open the Hierarchy panel.
  • Trigger the actor creation menu from different hierarchy contexts.
  • Verify the created actor is associated with the expected target actor context.

Screenshots/GIFs

N/A

AI Usage Disclosure

Debug

Checklist

  • My code follows the project's code style guidelines
  • When applicable, I have commented my code, particularly in hard-to-understand areas
  • When applicable, I have updated the documentation accordingly
  • My changes don't generate new warnings or errors
  • I have reviewed and take responsibility for all code in this PR (including any AI-assisted contributions)

@Gopmyc
Copy link
Copy Markdown
Contributor Author

Gopmyc commented May 11, 2026

I'm working on fixing that for Linux

@adriengivry
Copy link
Copy Markdown
Member

I'm working on fixing that for Linux

Nothing to be fixed, looks like a GitHub internal error. I'll restart the build.

@Gopmyc
Copy link
Copy Markdown
Contributor Author

Gopmyc commented May 11, 2026

I'm working on fixing that for Linux

Nothing to be fixed, looks like a GitHub internal error. I'll restart the build.

I was thinking that too, it’s weird that it doesn’t work on both sides

@adriengivry
Copy link
Copy Markdown
Member

I'm working on fixing that for Linux

Nothing to be fixed, looks like a GitHub internal error. I'll restart the build.

I was thinking that too, it’s weird that it doesn’t work on both sides

It's a server error. GitHub has been struggling lately, not surprised that build pipelines are failing for no reason.

@adriengivry adriengivry merged commit 9785f32 into Overload-Technologies:main May 11, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Create menu doesn't attach the new actor to the right actor

2 participants