Address feedback: ubuntu-slim is a valid runner label in docs preview workflow#481
Closed
Copilot wants to merge 1 commit intojmccall-schema-docs-publishfrom
Closed
Address feedback: ubuntu-slim is a valid runner label in docs preview workflow#481Copilot wants to merge 1 commit intojmccall-schema-docs-publishfrom
Copilot wants to merge 1 commit intojmccall-schema-docs-publishfrom
Conversation
Copilot started work on behalf of
Jennings Anderson (jenningsanderson)
March 23, 2026 15:57
View session
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on runner label validation in docs preview feature
Address feedback: ubuntu-slim is a valid runner label in docs preview workflow
Mar 23, 2026
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The automated Copilot reviewer incorrectly flagged
ubuntu-slimas an invalid GitHub-hosted runner label in.github/workflows/schema-pr-preview.yml. This label is a valid self-hosted runner registered in the OvertureMaps org — no code change is required. This PR acknowledges the feedback, corrects the false-positive review comment, and stores the fact to prevent future incorrect flagging.Reference
Testing
No functional change. The workflow already uses
ubuntu-slimcorrectly; the runner label is confirmed valid for this org.Checklist
Abut is not intended to test propertyA's validity, and you made a schema change that invalidates propertyAin that counterexample, fix the counterexample to align it with your schema change.Documentation website
Docs preview for this PR.
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.