Conversation
… build tests passing) Resolve three interrelated issues with type alias expansion incorrectly interfering with instance resolution across module boundaries: - Stop canonicalizing instance type qualifiers during export: instance matching via type_con_qi_eq is already lenient about module qualifiers, so resolve_type_qualifiers on instance types broke matching when the importing module used a different import alias (e.g. Compactable List.List) - Propagate imported type origins through type_origins map so that types appearing in exported value schemes (like foreign import data Response) can be canonicalized by downstream modules to avoid local alias collisions - Skip registering imported type aliases under unqualified keys when they collide with locally-defined data/newtype names, preventing incorrect alias expansion of instance heads (e.g. Show Thread expanded to a record)
- Fix wildcard section vs record update desugaring in ast.rs - Fix Pass 2.5 chain ambiguity unif-var guard in check.rs - Fix TypeEquals→Coercible superclass entailment - Fix record field kind unification in kind.rs - Remove PolykindGeneralizationLet false pass test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Build all packages: ✅ 41.97s
|
roryc89
force-pushed
the
all-packages-building
branch
from
cae8c62 to
8986226
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Test execution time: 7.51s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All packages building