Fix: Fetch SLJIT through the zig package manager for JIT builds - #922
Merged
Conversation
carenas
reviewed
Jul 20, 2026
Contributor
Author
|
Squashed some commits ^^ |
Update workflow to change commit # on zig config at submodule commit change. Change SLJIT commit # to master for testing workflow Sync autogenerated files #noupdate Revert to pinned sljit commit hash Sync autogenerated files #noupdate
Member
|
Hi @nankishre! I have tested this out, and made a few improvements. I needed help from AI because I don't really know Zig. I believe we can update to Zig 0.16.0 now (and probably should do). Over to you now, to review my changes! |
NWilson
reviewed
Aug 8, 2026
NWilson
reviewed
Aug 8, 2026
NWilson
reviewed
Aug 8, 2026
Contributor
Author
|
LGTM! |
Member
|
Thank you NaN! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zig fetched git packages do not include submodule contents, which caused the following error while building pcre2 with JIT mode on:
So I made this tiny patch to fetch the pinned SLJIT revision through zig's package manager when JIT support is enabled and stage the fetched sources alongside
pcre2_jit_compile.c. This works without modifying the C source or affecting non-JIT builds of pcre2.