Ignore JIT if a function is not compiled - #926
Conversation
|
I could not merge the two invalid utf code paths because of small differences. Instead, the |
|
Something is wrong with the code coverage public key. |
This a problem with the codecov plugin. They fixed it, but we had to update to the latest version of the CI widget. |
NWilson
left a comment
NWilson
left a comment
There was a problem hiding this comment.
Great, it looks good overall. I have some small suggestions but I don't think there are any actual bugs in here. Thanks!
| (options & ~PUBLIC_JIT_MATCH_OPTIONS) == 0); | ||
| if (re->executable_jit != NULL && | ||
| (options & ~PUBLIC_JIT_MATCH_OPTIONS) == 0) | ||
| use_jit = PRIV(jit_check_exec)(re->executable_jit, options); |
There was a problem hiding this comment.
You could keep the old structure, if you want, and just add an && PRIV(jit_check_exec)(...) at the end. I don't mind.
There was a problem hiding this comment.
I just deleted the use_jit variable.
|
Thank you for the review! Patch is updated |
|
Excellent! Thanks. |
2 participants
No description provided.