Conversation
… into et-validation
for more information, see https://pre-commit.ci
… into et-validation
for more information, see https://pre-commit.ci
… into et-validation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Removed signal alarm handling in exception block.
Updated the script to log output and check for errors.
for more information, see https://pre-commit.ci
Updated script to accept branch and suffix as arguments, streamlined output file naming.
Co-authored-by: Seth Gossage <sethg45@gmail.com>
Refactor ini content creation using dedent for better readability.
for more information, see https://pre-commit.ci
… candidate branch and data source
…further development
for more information, see https://pre-commit.ci
… into et-validation
for more information, see https://pre-commit.ci
Co-authored-by: Seth Gossage <sethg45@gmail.com>
Co-authored-by: Seth Gossage <sethg45@gmail.com>
Co-authored-by: Seth Gossage <sethg45@gmail.com>
Co-authored-by: Seth Gossage <sethg45@gmail.com>
for more information, see https://pre-commit.ci
Remove print statement for metallicity in simulation properties.
[fix/docs] `stepCEE` docstring change
[enhancement] Add basic info on `model_weight` units
Validate test binaries upon code changes
[v2.3] New grid paths section for `.ini` file
Unit tests for popsyn module
* add test for grid_path * add symlink for ubuntu tests * remove additional file but add followlinks=False explicitly * remove followlinks=False and try additional files * readd internal symlinks * sym link * add extra test file * revert 201->204 tests 'test' * different file check * try followlinks=True * skip islink in test coverage * claude opus suggestion? * Remove monkeypatch in func call
* Remove duplicated utility functions, consolidate in common_functions (fixes #442) The three functions in posydon/utils/gridutils.py that duplicated logic already present in posydon/utils/common_functions.py have been refactored: - kepler3_a(P, m1, m2) -> delegates to orbital_separation_from_period - T_merger_a(a, m1, m2) -> delegates to inspiral_timescale_from_separation (eccentricity=0, converts Myr->Gyr) - T_merger_P(P, m1, m2) -> delegates to inspiral_timescale_from_orbital_period (eccentricity=0, converts Myr->Gyr) * Remove deprecated functions from gridutils, move beta_gw to common_functions - Remove kepler3_a, T_merger_P, T_merger_a entirely from gridutils.py; their canonical counterparts in common_functions.py are now the only implementations. - Move beta_gw from gridutils.py into common_functions.py so all GW inspiral helpers live in one place. - Replace the internal T_merger_P call in convert_output_to_table with a direct call to inspiral_timescale_from_orbital_period. - Drop now-unused constant imports from gridutils.py (Msun, Rsun, clight, cgrav, secyear). - Update test_gridutils.py: remove elements and tests for the four deleted functions. - Update test_common_functions.py: add beta_gw to the elements set and add test_instance_beta_gw + test_beta_gw.
* add to_df method for LazyHDF5 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove test coverage from to_df() * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incrementing to version 2.3