[fix/enhancement] Remove forced lower mass ratio limit #819
Open
[fix/enhancement] Remove forced lower mass ratio limit #819
Conversation
| synpop_params = binarypop_kwargs_from_ini(args.ini_file) | ||
| # warn if mass ratio q = M2/M1 could fall below 0.05 | ||
| if synpop_params['secondary_mass_scheme'] == 'flat_mass_ratio': | ||
| q_min_possible = (synpop_params['secondary_mass_min'] |
Contributor
There was a problem hiding this comment.
If I understand correctly, the q_min_possible should return a theoretically lowest case value, not a minimum from our actual sampling, right?
Collaborator
Author
There was a problem hiding this comment.
Yes. Our sampling technically should never be below the theoretical minimum. I wanted to warn the user that their settings are allowing the sampler to return values below the grid values :)
Contributor
|
As @maxbriel, pointed out, this PR currently has a failed assertion check in the unit tests that needs to be looked at more closely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains PR #797 !
This PR removes the lower mass ratio limit that's forced by
initial_sampling.Additionally, it adds a warning when setting up a population synthesis run. if q<0.05 is sampled.