[enhancement] Add power law mass ratio options for reweighting#837
Open
[enhancement] Add power law mass ratio options for reweighting#837
Conversation
sgossage
approved these changes
Apr 22, 2026
sgossage
reviewed
Apr 22, 2026
|
|
||
| from posydon.utils.common_functions import inverse_sampler | ||
|
|
||
| n_points = 1000 |
Contributor
There was a problem hiding this comment.
Should we make n_points an argument vs. hard coded?
sgossage
reviewed
Apr 22, 2026
| >>> pdf_value = dist.pdf(0.5) | ||
| """ | ||
|
|
||
| def __init__(self, alpha=0.0, q_min=0.05, q_max=1.0): |
Contributor
There was a problem hiding this comment.
Not strictly necessary for this PR, but it looks like this class has some overlap with FlatMassRatio and we could create a parent class that this class and that class are children of, modifying just the relevant parts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the user to request a mass ratio distribution following a (requested) power law slope.
Usage example: