fix(ubx): correct CFG-UART1/2-ENABLED configuration key IDs - #229
Merged
Merged
Conversation
Both keys are type L, so the storage-size nibble must be 1, not 2. As written the receiver NAKs any CFG-VALSET carrying them, taking every other key in the same message down with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CFG-UART1-ENABLEDandCFG-UART2-ENABLEDcarried the wrong key IDs. Same fix as the drive-by in #222, split out so it can land on its own.Problem
Both items are type
L, so the storage-size nibble is1:0x10520005and0x10530005per the F9 HPG 1.51 and X20 HPG 2.10 interface descriptions. The header had0x2052_0005/0x2053_0005, which is the encoding for a one-byte item and matches no configuration item on any receiver. A CFG-VALSET containing either key is NAKed, and the NAK discards every other key packed into that message.Nothing on main sends them today, so this is latent, but it blocks any use of the keys — the u-center UART2 mode in #228 is the first caller.
Solution
Use the IDs from the interface descriptions.