Skip to content

Fix platform icon proportions and adaptive padding - #85

Merged
Eoic merged 1 commit into
developmentfrom
fix/platform-icon-proportions
Oct 24, 2026
Merged

Eoic merged 1 commit into
developmentfrom
fix/platform-icon-proportions

Conversation

@Eoic

@Eoic Eoic commented Oct 24, 2026

Copy link
Copy Markdown
Member

Issue and requirements

Closes #84. Maintainer-reported branding defect with no dedicated requirement ID.

Summary

Android and iOS stretched the tall Papyrus emblem into a square. Regenerate the client icons from the canonical SVG with proportional scaling and platform padding. Add Android adaptive icons, safe web maskable icons, and Papyrus replacements for the macOS and Windows Flutter templates.

Add an icon generator and CI validation for artwork, dimensions, opacity, catalog/manifest sizes, and masking safe zones. Maintenance instructions live in the generator's --help.

Testing

Passed locally:

  • uv run tools/generate_icons.py --check: 38 PNGs and 10 Windows ICO resolutions.
  • Repeated generation produced identical bytes. Validation rejected stretched artwork, wrong dimensions, and unexpected alpha.
  • tools/papyrus check client: formatting, analysis, and four web bootstrap tests.
  • tools/papyrus test client -- test/widgets/auth/auth_page_layouts_test.dart test/widgets/shell/desktop_sidebar_test.dart: 11 tests.
  • Android debug APK compilation and inspection of the packaged adaptive-icon XML.
  • iOS and macOS asset-catalog compilation with actool.
  • git diff --check.

UI evidence

Android legacy bitmap comparison. These are exported assets, not device screenshots.

Before After
Stretched Android icon Proportional Android icon

Also inspected generated circle, squircle, and rounded-square adaptive previews without clipping.

Compatibility and migration

No migrations or version changes. Android 26+ uses adaptive layers. Legacy bitmap icons remain available.

Notes

Samsung launcher acceptance remains pending because no Android device was connected. Windows/Linux runtime appearance was not tested. The Android build passed with an SDK XML-version warning.

Checklist

  • The branch, commits, and pull request title follow the repository conventions.
  • The change is complete and limited to the agreed scope.
  • Relevant tests have been added or updated.
  • Formatting, analysis, and tests pass locally.
  • Documentation, UI evidence, and migration notes are included where relevant.
  • No credentials, personal data, copyrighted fixtures, or unrelated generated files are included.
  • The branch is up to date with its target branch.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 13:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T13:20:09.043053Z 52fb7ba PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Eoic
Eoic merged commit b1cbe8e into development Oct 24, 2026
5 checks passed
@Eoic
Eoic deleted the fix/platform-icon-proportions branch October 24, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve original artwork proportions in platform icons

2 participants