Skip to content

Fix Windows setup artwork, shortcuts, and release validation - #91

Merged
Eoic merged 4 commits into
developmentfrom
fix/windows-release-readiness
Oct 24, 2026
Merged

Eoic merged 4 commits into
developmentfrom
fix/windows-release-readiness

Conversation

@Eoic

@Eoic Eoic commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Issue and requirements

Closes #92. User-reported Windows setup and release-preparation defects.

Summary

Windows setup lacked branded wizard artwork and a desktop shortcut choice, and the native window title was lowercase. Setup now uses proportional crops of the client's welcome-page illustration and offers an optional desktop shortcut. The window title and executable description display Papyrus.

Installer and ZIP checks verify complete bundle contents, launch behavior, and the exact window title. Installer checks cover shortcut selection, its preservation across reinstall, and cleanup on uninstall. Packaged-reader tests cover both installer and ZIP distributions. Windows CI runs for app changes and saves a production-entrypoint preview with public production endpoints, checksums, source provenance, and a manual acceptance checklist.

Testing

All checks pass on commit daee6446b23d0010ae92643317b2f6383a756d1b:

  • Windows packaging: missing-WebView2 installation, installer/ZIP file integrity and launch, title and shortcuts, EPUB/PDF rendering, offline import/resume/profile isolation, and data/credential retention across fixture upgrade, uninstall, and reinstall.
  • Client code quality, platform assets, release tooling, Linux compilation, and Codecov checks pass.
  • Local asset validation checks 40 platform images and 10 ICO frames. Actionlint and diff whitespace checks pass. All 47 release-tool tests pass.
  • The maintainer confirmed the functional preview works on a real Windows machine and approved the final illustration crops. Final artwork in the native installer can be checked with docs/WINDOWS_TESTING.md.

Download the latest Windows preview. It includes the normal application installer and ZIP, SHA256SUMS, BUILD-INFO.json, and WINDOWS_TESTING.md. Artifacts are retained for 14 days.

UI evidence

Setup uses app/assets/images/welcome-illustration.png, cropped around the lamp and books for the portrait sidebar and square header. Both generated crops were visually reviewed and approved by the maintainer.

Compatibility and migration

No application version or storage identity changes. CompanyName=com.papyrus and ProductName=papyrus remain stable because Windows storage plugins derive library and credential paths from them. The desktop shortcut is optional and unchecked on a fresh installation. Preview builds retain manifest version 0.1.0+5 and identify their source in BUILD-INFO.json.

Notes

No signing or public release changes. The local reader override in app/pubspec.lock is excluded. Real-machine acceptance instructions include published-release upgrades, display scaling, and interactive authentication/sync.

Copilot AI balanced review requested due to automatic review settings October 24, 2026 20:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-24T20:53:49.552771Z 7b39683 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Eoic Eoic changed the title Fix Windows setup branding and validate release downloads Fix Windows setup artwork, shortcuts, and release validation Oct 24, 2026
@Eoic
Eoic merged commit 159c894 into development Oct 24, 2026
6 checks passed
@Eoic
Eoic deleted the fix/windows-release-readiness branch October 24, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete Windows setup branding and release validation

2 participants