Repository navigation
[#x] 리뷰아이템 코드 리팩토링 - #238
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
wlrnjs
reviewed
Oct 23, 2025
wlrnjs
reviewed
Oct 24, 2025
wlrnjs
self-requested a review
October 24, 2025 17:51
wlrnjs
previously approved these changes
Oct 24, 2025
wlrnjs
previously approved these changes
Oct 24, 2025
wlrnjs
approved these changes
Oct 24, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 PR 내용 요약
wine-review-item컴포넌트 분리✅ 작업 내용 상세
wine-review-header,wine-review-footer두 파일로 코드 분리💬 참고 사항
일단 지권님이 말씀해주신 방식으로 코드만 분리해봤습니다.
지금은
wine-review-item에서 ui렌더링만 하고있는데 다른 파일들도 동일한 방식으로 리팩토링하면 좋을까요?또한
wine-review-header에서도 옵션버튼/좋아요버튼을 따로 컴포넌트로 뺴는게 좋을지 고민이됩니다.컴파운드 패턴도 공부해서 적용해볼까하는데 너무 대규모 작업인지도 생각이 드네요..
리뷰는 자유입니다!
안달아주셔도되고 달아주시면 감사히 반영해보겠습니다.