Security: Insecure Direct Object Reference in Template Loading#824
Merged
aeifn merged 1 commit intoJul 6, 2026
Merged
Conversation
The `controllers/tpl.js` file loads templates based on user-provided path parameters. While it does check against a whitelist (`tpls.includes(tplPath)`), the path construction uses string concatenation (`'module/' + tplPath`) which could potentially be bypassed if the whitelist check has flaws or if path traversal sequences are somehow processed. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Insecure Direct Object Reference in Template Loading
Problem
Severity:
Medium| File:controllers/tpl.js:L17The
controllers/tpl.jsfile loads templates based on user-provided path parameters. While it does check against a whitelist (tpls.includes(tplPath)), the path construction uses string concatenation ('module/' + tplPath) which could potentially be bypassed if the whitelist check has flaws or if path traversal sequences are somehow processed.Solution
Use path.join with proper normalization, ensure strict path validation against an allowlist, and consider using a more robust template resolution mechanism that doesn't rely on user-provided path granularity.
Changes
controllers/tpl.js(modified)