PBM-1756: Adding e2e tests scenarios not already covered#578
Open
keithquinnpercona wants to merge 32 commits into
Open
PBM-1756: Adding e2e tests scenarios not already covered#578keithquinnpercona wants to merge 32 commits into
keithquinnpercona wants to merge 32 commits into
Conversation
…rements and continuous writes.
…rements and continuous writes.
keithquinnpercona
requested review from
olexandr-havryliak and
sandraromanchenko
as code owners
July 8, 2026 10:25
Contributor
There was a problem hiding this comment.
Pull request overview
Adds multiple new PBM end-to-end scenarios (PITR, selective restore, agent interruptions, clock skew, distributed transactions) to expand functional coverage of backup/restore behavior across different cluster topologies, and introduces a small Cluster helper to support PITR-timestamp selection.
Changes:
- Added new e2e tests covering: unsharded timeseries PITR, selective restore, backup interruption/cancel behavior, leader/agent lag, distributed transactions, clock skew handling, and restore metadata cleanup.
- Updated incremental backup tests (replicaset + sharded) to run with continuous writes during incremental backup creation.
- Updated the pytest image to install
libfaketimeand addedCluster.get_last_pitr_chunk_end()to support PITR testing.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pbm-functional/pytest/test_timeseries.py | Adds an unsharded timeseries PITR test with concurrent writers and restore verification. |
| pbm-functional/pytest/test_sharded.py | Updates incremental test to run under continuous writes; adds “lost shard agent mid-backup” scenario; changes storage-config parametrization. |
| pbm-functional/pytest/test_selective_restore.py | New selective backup + selective restore coverage for replicaset and sharded layouts. |
| pbm-functional/pytest/test_replicaset.py | Updates incremental test to run under continuous writes and verify restore correctness. |
| pbm-functional/pytest/test_PBM-1344.py | Adds S3/MinIO validation that delete-backup removes remote artifacts. |
| pbm-functional/pytest/test_leader_lag.py | New test ensuring a paused CSRS agent can resume and complete a backup, then survives resync/restore. |
| pbm-functional/pytest/test_distributed_trx.py | New PITR + physical tests validating behavior with cross-shard distributed transactions. |
| pbm-functional/pytest/test_clockskew.py | New logical/physical tests for backup/restore correctness with per-shard clock skew via faketime. |
| pbm-functional/pytest/test_cleanup_restore.py | New test validating restore cleans up chunk routing metadata changes after snapshot. |
| pbm-functional/pytest/test_backup_interruption.py | New tests for cancel-backup cleanup and delete-backup behavior during an active backup. |
| pbm-functional/pytest/Dockerfile | Installs libfaketime to enable clock-skew testing. |
| pbm-functional/pytest/cluster.py | Adds helper to fetch the latest PITR chunk end timestamp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
olexandr-havryliak
approved these changes
Jul 13, 2026
sandraromanchenko
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.