Skip to content

PXB-3824 Add check-tables to automated backup test regression#8

Merged
saikumar-vs merged 13 commits into
mainfrom
check-tables-fix
Jul 7, 2026
Merged

PXB-3824 Add check-tables to automated backup test regression#8
saikumar-vs merged 13 commits into
mainfrom
check-tables-fix

Conversation

@saikumar-vs

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PXB automated backup regression scripts to automatically enable --check-tables during xtrabackup --prepare when running on Percona XtraBackup versions that support it (>= 8.4.0-6), improving validation coverage during backup/restore testing.

Changes:

  • Add XtraBackup version parsing/normalization that includes the -<release> component (e.g., 8.4.0-6).
  • Introduce a helper to build --prepare argument lists and automatically append --check-tables for supported PXB versions.
  • Minor deduplication by setting restore_params = prepare_params in several component-encryption flows.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test_scripts/pxb/upgrade_backup_tests.py Uses the new helper prepare-args builder so upgrade prepare steps can auto-add --check-tables when supported.
test_scripts/pxb/test_helper.py Adds PXB version normalization including release, introduces version-gated prepare arg augmentation (--check-tables), and removes some duplicated param construction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tplavcic tplavcic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just write a description about why does one version normalization function not work for both PS and PXB considering that PS versions look like 8.4.10-10 and PXB 8.4.0-6, so they both have the last digit after dash character.

@saikumar-vs

Copy link
Copy Markdown
Contributor Author

Can you just write a description about why does one version normalization function not work for both PS and PXB considering that PS versions look like 8.4.10-10 and PXB 8.4.0-6, so they both have the last digit after dash character.

Thanks updated the comment to highlight the difference

@saikumar-vs saikumar-vs closed this Jul 6, 2026
@saikumar-vs saikumar-vs reopened this Jul 6, 2026
…tection of changed files and integrating reviewdog for PR checks. Added conditional steps for running linters based on file changes and updated installation procedures.
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Comment thread test_scripts/pxb/partial_backup_tests.sh Outdated
Comment thread test_scripts/pxb/pxb_helper.sh Fixed
@saikumar-vs saikumar-vs merged commit b97efb3 into main Jul 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants