PXB-3824 Add check-tables to automated backup test regression#8
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the PXB automated backup regression scripts to automatically enable --check-tables during xtrabackup --prepare when running on Percona XtraBackup versions that support it (>= 8.4.0-6), improving validation coverage during backup/restore testing.
Changes:
- Add XtraBackup version parsing/normalization that includes the
-<release>component (e.g.,8.4.0-6). - Introduce a helper to build
--prepareargument lists and automatically append--check-tablesfor supported PXB versions. - Minor deduplication by setting
restore_params = prepare_paramsin several component-encryption flows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test_scripts/pxb/upgrade_backup_tests.py |
Uses the new helper prepare-args builder so upgrade prepare steps can auto-add --check-tables when supported. |
test_scripts/pxb/test_helper.py |
Adds PXB version normalization including release, introduces version-gated prepare arg augmentation (--check-tables), and removes some duplicated param construction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tplavcic
left a comment
There was a problem hiding this comment.
Can you just write a description about why does one version normalization function not work for both PS and PXB considering that PS versions look like 8.4.10-10 and PXB 8.4.0-6, so they both have the last digit after dash character.
Thanks updated the comment to highlight the difference |
…tection of changed files and integrating reviewdog for PR checks. Added conditional steps for running linters based on file changes and updated installation procedures.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
No description provided.