Skip to content

ci: register typed_array_update_lowering in the e2e-scoped suite map - #11675

Merged
proggeramlug merged 2 commits into
mainfrom
fix/e2e-map-typed-array-update-lowering
Sep 29, 2026
Merged

proggeramlug merged 2 commits into
mainfrom
fix/e2e-map-typed-array-update-lowering

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

#11666 added the integration suite crates/perry-codegen/tests/typed_array_update_lowering.rs without adding it to scripts/ci_e2e_scope.py. e2e-scoped requires every perry-codegen suite to be either in _CODEGEN_SUITES (via SOURCE_SUITE_MAP) or in SUITE_EXCLUSIONS. So since #11666, every PR that touches perry-codegen fails e2e-scoped at "Compute e2e suite scope" with:

these crates/perry-codegen/tests/*.rs suites are in neither SOURCE_SUITE_MAP nor SUITE_EXCLUSIONS: typed_array_update_lowering

The suite passed as a diff-named suite on #11666's own CI, so it belongs in the map, not in the exclusions.

  • python3 scripts/ci_e2e_scope.py --self-test passes.
  • A perry-codegen source change now selects typed_array_update_lowering.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 09153b2c-e157-488e-baeb-1caaa3fbfbf1

📥 Commits

Reviewing files that changed from the base of the PR and between 170e083 and ae7c691.

📒 Files selected for processing (2)
  • changelog.d/11675-e2e-map-typed-array-update-lowering.md
  • scripts/ci_e2e_scope.py
 ____________________________________________________________________________________________________________________________________________________________________
< Use blackboards to coordinate workflow. Use blackboards to coordinate disparate facts and agents, while maintaining independence and isolation among participants. >
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit 74fed83 into main Sep 29, 2026
31 of 34 checks passed
@proggeramlug
proggeramlug deleted the fix/e2e-map-typed-array-update-lowering branch September 29, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant