Open
Conversation
Owner
|
Thanks for the PR, why is it needed when this is done in the main function? adjustText/adjustText/__init__.py Line 414 in bc938b4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #143, where adjustText does not properly position text labels when using the %matplotlib notebook backend in Jupyter Notebook.
The issue appears to be related to the calculation of bounding boxes for scatter plot elements in the get_bboxes_pathcollection function. By updating the canvas before calculating the bounding boxes (adding
ax.figure.canvas.draw()at the beginning of the function), the issue is resolved, and adjustText works correctly with %matplotlib notebook.The fix was suggested by ChatGPT, an AI language model by OpenAI.