-
Notifications
You must be signed in to change notification settings - Fork 3
Add async get_raw_access_token() method to AsyncPipedream #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
4
commits into
main
Choose a base branch
from
copilot/make-raw-access-token-async
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,49 @@ | ||
| from unittest.mock import AsyncMock | ||
|
|
||
| import pytest | ||
|
|
||
| from pipedream import AsyncPipedream, Pipedream | ||
|
|
||
|
|
||
| # Get started with writing tests with pytest at https://docs.pytest.org | ||
| @pytest.mark.skip(reason="Unimplemented") | ||
| def test_client() -> None: | ||
| assert True | ||
|
|
||
|
|
||
| def test_sync_pipedream_raw_access_token() -> None: | ||
| """Test synchronous Pipedream client raw_access_token property.""" | ||
| client = Pipedream(access_token="test-token", project_id="test-project") | ||
| assert client.raw_access_token == "test-token" | ||
|
|
||
|
|
||
| def test_async_pipedream_raw_access_token() -> None: | ||
| """Test AsyncPipedream client raw_access_token property with access_token.""" | ||
| client = AsyncPipedream(access_token="test-token", project_id="test-project") | ||
| assert client.raw_access_token == "test-token" | ||
|
|
||
|
|
||
| async def test_async_pipedream_async_raw_access_token() -> None: | ||
| """Test AsyncPipedream async method async_raw_access_token() with access_token.""" | ||
| client = AsyncPipedream(access_token="test-token", project_id="test-project") | ||
| token = await client.async_raw_access_token | ||
| assert token == "test-token" | ||
|
|
||
|
|
||
| async def test_async_pipedream_async_raw_access_token_with_oauth() -> None: | ||
| """Test AsyncPipedream async method with OAuth flow.""" | ||
| client = AsyncPipedream( | ||
| client_id="test-client-id", | ||
| client_secret="test-client-secret", | ||
| project_id="test-project", | ||
| ) | ||
|
|
||
| # The client should have _async_token set when using OAuth | ||
| assert client._client_wrapper._async_token is not None | ||
|
|
||
| # Mock the async token provider | ||
| client._client_wrapper._async_token = AsyncMock(return_value="mocked-oauth-token") | ||
|
|
||
| # Test the async method | ||
| token = await client.async_raw_access_token | ||
| assert token == "mocked-oauth-token" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: PipedreamHQ/pipedream-sdk-python
Length of output: 2919
🏁 Script executed:
Repository: PipedreamHQ/pipedream-sdk-python
Length of output: 4973
Remove the assertion on line 42 to avoid testing private implementation details.
The assertion
assert client._client_wrapper._async_token is not Nonedirectly accesses a private attribute (_async_token), creating tight coupling to implementation details. Since the test verifies the actual behavior through the public API at line 48 (token = await client.async_raw_access_token), the assertion is redundant. If OAuth initialization fails, the behavioral test will catch it when attempting to retrieve the token. Removing line 42 makes the test cleaner and less dependent on internal state.Note: Line 45 (mocking
_async_token) is acceptable since there is no public setter and mocking is necessary to test the async token provider behavior.🧰 Tools
🪛 Ruff (0.14.8)
37-37: Possible hardcoded password assigned to argument: "client_secret"
(S106)
49-49: Possible hardcoded password assigned to: "token"
(S105)
🤖 Prompt for AI Agents