Skip to content

Conversation

@maycon-pipedream
Copy link

@maycon-pipedream maycon-pipedream commented Dec 11, 2025

Closes #19404

This PR updates the SMS sending component to use Infobip’s SMS API v3.

Previously, SMS messages were not being delivered because the payload format was still using the v2 structure, which is incompatible with the current API requirements.

  • Key Changes

Migrated the SMS payload from API v2 to API v3 format.

Updated message structure:

  1. from → sender
  2. Message text is now sent via content.text
  3. Adjusted the messages object to match the v3 specification.

Fixed the issue where text messages were not being sent due to the incorrect payload structure.

Updated the request to use the /sms/3/messages endpoint.

  • Result

The SMS component now sends messages correctly and is fully aligned with Infobip’s latest API standards.

Summary by CodeRabbit

  • New Features

    • Improved SMS payload: sender and message content handled explicitly for clearer delivery.
  • Bug Fixes

    • SMS API endpoint updated to the newer path for improved compatibility.
  • Chores

    • Version bumps across Infobip component, SMS action, Viber/WhatsApp actions, and message sources.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit Ignored Ignored Dec 12, 2025 3:22pm

@pipedream-component-development
Copy link
Collaborator

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development
Copy link
Collaborator

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Walkthrough

SMS and related Infobip components updated: send-sms action payload shape changed (top-level sender, content: { text }, concise destinations), sendSms API path moved to /sms/3/messages, and multiple components' version fields incremented.

Changes

Cohort / File(s) Summary
Send SMS Action Implementation
components/infobip/actions/send-sms/send-sms.mjs
Action version bumped 0.0.2 → 0.0.3. run() now destructures { infobip, phoneNumber, sender, text, ...rest }. Message payload rebuilt to include top-level sender, destinations: [{ to: phoneNumber }], content: { text }, and spread ...rest.
API Integration
components/infobip/infobip.app.mjs
sendSms request path updated from /sms/2/text/advanced to /sms/3/messages. Method signature/options unchanged.
Package Version
components/infobip/package.json
Package version bumped 0.1.0 → 0.1.1.
Other Component Version Bumps
components/infobip/actions/send-viber-text-message/send-viber-text-message.mjs, components/infobip/actions/send-whatsapp-text-message/send-whatsapp-text-message.mjs, components/infobip/sources/new-sms-message-instant/new-sms-message-instant.mjs, components/infobip/sources/new-whatsapp-message-instant/new-whatsapp-message-instant.mjs
Metadata version fields incremented (various files: 0.0.1/0.0.2 → 0.0.2/0.0.3). No behavioral changes reported.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

  • Review the new SMS payload against Infobip v3/messages API (fields: sender, destinations, content, additional message-level fields).
  • Confirm sender and text are present in action props and validated where required.
  • Verify the endpoint change aligns with auth/headers and any downstream expectations (rate limits, response shape).
  • Quick check of bumped-version files to ensure no unintended logic or export changes.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the SMS route and payload structure for Infobip API compatibility.
Description check ✅ Passed The description provides comprehensive context including the issue reference, API migration rationale, key changes, and expected result.
Linked Issues check ✅ Passed The PR fully addresses the objective from issue #19404 by migrating the SMS payload from API v2 to v3 format and updating the endpoint to /sms/3/messages.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the SMS sending functionality; version bumps are appropriately applied across related components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29e5d29 and 29f17cd.

📒 Files selected for processing (5)
  • components/infobip/actions/send-sms/send-sms.mjs (2 hunks)
  • components/infobip/actions/send-viber-text-message/send-viber-text-message.mjs (1 hunks)
  • components/infobip/actions/send-whatsapp-text-message/send-whatsapp-text-message.mjs (1 hunks)
  • components/infobip/sources/new-sms-message-instant/new-sms-message-instant.mjs (1 hunks)
  • components/infobip/sources/new-whatsapp-message-instant/new-whatsapp-message-instant.mjs (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-20T01:01:02.970Z
Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 18744
File: components/slack_v2/actions/send-large-message/send-large-message.mjs:49-64
Timestamp: 2025-10-20T01:01:02.970Z
Learning: In components/slack_v2/actions/send-large-message/send-large-message.mjs, the metadata_event_payload prop is typed as string, so the code only needs to handle string-to-JSON parsing and does not need to handle object inputs.

Applied to files:

  • components/infobip/actions/send-viber-text-message/send-viber-text-message.mjs
  • components/infobip/actions/send-sms/send-sms.mjs
  • components/infobip/actions/send-whatsapp-text-message/send-whatsapp-text-message.mjs
🧬 Code graph analysis (1)
components/infobip/actions/send-sms/send-sms.mjs (1)
components/infobip/actions/send-whatsapp-text-message/send-whatsapp-text-message.mjs (1)
  • response (51-59)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Lint Code Base
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Publish TypeScript components
  • GitHub Check: pnpm publish
🔇 Additional comments (6)
components/infobip/sources/new-whatsapp-message-instant/new-whatsapp-message-instant.mjs (1)

9-9: Version bump looks consistent with a metadata-only release.

components/infobip/actions/send-viber-text-message/send-viber-text-message.mjs (1)

7-7: Version bump only — LGTM.

components/infobip/actions/send-whatsapp-text-message/send-whatsapp-text-message.mjs (1)

7-7: Version bump only — LGTM.

components/infobip/sources/new-sms-message-instant/new-sms-message-instant.mjs (1)

9-9: Version bump only — LGTM.

components/infobip/actions/send-sms/send-sms.mjs (2)

7-7: Version bump matches the functional change in this action.


64-91: File not found in repository. Unable to verify claims about code structure, prop definitions, or the alleged sender/from mismatch. The file components/infobip/actions/send-sms/send-sms.mjs does not exist in the current repository state. Confirm the file path and verify that the code changes have been committed before proceeding with this review.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM, ready for QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

User submitted Submitted by a user

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Infobip Send SMS not working

4 participants