-
Notifications
You must be signed in to change notification settings - Fork 5.6k
fix: updating the route and payload to send sms #19464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: updating the route and payload to send sms #19464
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
WalkthroughSMS and related Infobip components updated: send-sms action payload shape changed (top-level Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (5)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-10-20T01:01:02.970ZApplied to files:
🧬 Code graph analysis (1)components/infobip/actions/send-sms/send-sms.mjs (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
michelle0927
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! LGTM, ready for QA.
Closes #19404
This PR updates the SMS sending component to use Infobip’s SMS API v3.
Previously, SMS messages were not being delivered because the payload format was still using the v2 structure, which is incompatible with the current API requirements.
Migrated the SMS payload from API v2 to API v3 format.
Updated message structure:
Fixed the issue where text messages were not being sent due to the incorrect payload structure.
Updated the request to use the /sms/3/messages endpoint.
The SMS component now sends messages correctly and is fully aligned with Infobip’s latest API standards.
Summary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.