Add Transform limits to the camera position #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bit_transform could probably be better replaced witha match statement.
Plonq
reviewed
Dec 17, 2025
Owner
Plonq
left a comment
Plonq
left a comment
There was a problem hiding this comment.
Thanks for PR. Initial review, haven't tested it yet.
Comment on lines
+288
to
+299
| /// Adding maximum x bound for the camera transform. Default value of None has no bound. | ||
| pub camera_transform_x_max: Option<f32>, | ||
| /// Adding minimum x bound for the camera transform. Default value of None has no bound. | ||
| pub camera_transform_x_min: Option<f32>, | ||
| /// Adding maximum y bound for the camera transform. Default value of None has no bound. | ||
| pub camera_transform_y_max: Option<f32>, | ||
| /// Adding minimum y bound for the camera transform. Default value of None has no bound. | ||
| pub camera_transform_y_min: Option<f32>, | ||
| /// Adding maximum z bound for the camera transform. Default value of None has no bound. | ||
| pub camera_transform_z_max: Option<f32>, | ||
| /// Adding minimum z bound for the camera transform. Default value of None has no bound. | ||
| pub camera_transform_z_min: Option<f32>, |
Owner
There was a problem hiding this comment.
Is there any reason not to use a single Cuboid? You could potentially use closest_point() to do the constraining.
| new_transform.rotation *= yaw_rot * pitch_rot; | ||
| new_transform.translation += focus + new_transform.rotation * Vec3::new(0.0, 0.0, radius); | ||
| if (x_max.is_some()) && (new_transform.translation.x > x_max.unwrap()) { | ||
| return false; |
Owner
There was a problem hiding this comment.
Returning bool seems unnecessary. Just clamp/constrain it - if the values end up being the same as before, it doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty gross initial edit I dashed out in about an hour. I am not proud of the list of If statements in update_orbit_transform, but its what made sense and seemed easiest to debug when I was writing. The list of If statements could probably be replaced with a match statement that returns the appropriate boolean. Also, it might be nicer to just have the update return the new_transform and then do these comparisons around lib.rs line 825 or so. I wasn't sure how I would go about testing these edits, so they are completely untested at this time.