Skip to content

Add missing store link metadata#2286

Draft
offalynne wants to merge 6 commits intoPortsMaster:mainfrom
offalynne:main
Draft

Add missing store link metadata#2286
offalynne wants to merge 6 commits intoPortsMaster:mainfrom
offalynne:main

Conversation

@offalynne
Copy link
Copy Markdown

@offalynne offalynne commented Feb 8, 2026

Store links for all non-RTR ports

@tabreturn
Copy link
Copy Markdown
Collaborator

Thanks for submitting this, @offalynne. However, there are several errors --

[96](https://github.com/PortsMaster/PortMaster-New/actions/runs/21803537283/job/62926486912?pr=2286#step:3:3297)
Error: blossomtales2: Unable to load ports/blossomtales2/port.json: Expecting value: line 33 column 5 (char 1223)
Error: firework: Unable to load ports/firework/port.json: Expecting property name enclosed in double quotes: line 30 column 7 (char 749)
Error: half-life: Unable to load ports/half-life/port.json: Expecting value: line 33 column 9 (char 1225)
Error: iortcw: Unable to load ports/iortcw/port.json: Expecting value: line 34 column 9 (char 1057)
Error: jubilee: Unable to load ports/jubilee/port.json: Expecting property name enclosed in double quotes: line 30 column 7 (char 769)
Warning: missiledancer: port_info['attr']['genres'] contains bad genre shump
Warning: yellowjacket: port_info['attr']['genres'] contains bad genre shump

You can run a check on your PC before submitting to catch and fix this kind of stuff :)
See: https://portmaster.games/packaging.html#creating-a-pull-request

@offalynne
Copy link
Copy Markdown
Author

offalynne commented Feb 9, 2026

@tabreturn thank you for the review ! I have submitted changes to clear the errors this PR introduced.

The following are not a product of my changes as this data is untouched by my commits

Warning: missiledancer: port_info['attr']['genres'] contains bad genre shump
Warning: yellowjacket: port_info['attr']['genres'] contains bad genre shump

I can append to this PR to fix these warnings, but perhaps a separate PR is in order ?

@tabreturn
Copy link
Copy Markdown
Collaborator

@tabreturn #2287

Sorry -- checks have failed again. This won't merge. It seems you'll have to fix the shump errors. Not sure why you're getting this -- maybe you need to clone a fresh fork and apply your changes to it.

@offalynne offalynne marked this pull request as draft February 9, 2026 23:22
@offalynne offalynne marked this pull request as ready for review February 10, 2026 00:32
@bmdhacks
Copy link
Copy Markdown
Contributor

Note this was attempted earlier but never shipped because it would force rebuild/redownload of all ports and kill our bandwidth (and people's handhelds).

#1469

@offalynne
Copy link
Copy Markdown
Author

it would force rebuild/redownload of all ports

does not seem correct to be forever stuck with bad/out of date metadata because any change forces rebuild. if this is in fact the case (i have not confirmed it is) perhaps the workflow should change so as not to rebuild if version number is unchanged?

@bmdhacks
Copy link
Copy Markdown
Contributor

it would force rebuild/redownload of all ports

does not seem correct to be forever stuck with bad/out of date metadata because any change forces rebuild. if this is in fact the case (i have not confirmed it is) perhaps the workflow should change so as not to rebuild if version number is unchanged?

Yes, that's the blocking change for these improvements. I believe klops has that implemented, I'm not sure, but yes it's what we need to do first. Nobody is suggesting we stagnate at the current behavior.

@offalynne
Copy link
Copy Markdown
Author

@kloptops

@kloptops
Copy link
Copy Markdown
Contributor

Yeah i have an idea of what i need to do, but haven't figured out the logic to do it.

Mental bandwidth is low at the moment. 😓

@tabreturn tabreturn self-requested a review February 14, 2026 00:51
@tabreturn tabreturn marked this pull request as draft February 14, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants