Add missing store link metadata#2286
Conversation
|
Thanks for submitting this, @offalynne. However, there are several errors -- You can run a check on your PC before submitting to catch and fix this kind of stuff :) |
|
@tabreturn thank you for the review ! I have submitted changes to clear the errors this PR introduced. The following are not a product of my changes as this data is untouched by my commits I can append to this PR to fix these warnings, but perhaps a separate PR is in order ? |
|
Sorry -- checks have failed again. This won't merge. It seems you'll have to fix the |
|
Note this was attempted earlier but never shipped because it would force rebuild/redownload of all ports and kill our bandwidth (and people's handhelds). |
does not seem correct to be forever stuck with bad/out of date metadata because any change forces rebuild. if this is in fact the case (i have not confirmed it is) perhaps the workflow should change so as not to rebuild if version number is unchanged? |
Yes, that's the blocking change for these improvements. I believe klops has that implemented, I'm not sure, but yes it's what we need to do first. Nobody is suggesting we stagnate at the current behavior. |
|
Yeah i have an idea of what i need to do, but haven't figured out the logic to do it. Mental bandwidth is low at the moment. 😓 |
Store links for all non-RTR ports