This repository was archived by the owner on Jun 25, 2025. It is now read-only.
feat: option to exclude specific events#15
Open
yusufumac wants to merge 1 commit into
Open
Conversation
|
@neilkakkar fyi |
neilkakkar
reviewed
May 26, 2022
neilkakkar
left a comment
neilkakkar
left a comment
There was a problem hiding this comment.
Code looks good, but would also be nice to have some validation in setupPlugin that ensures users can't make mistakes: We don't want to allow someone to set both eventsToSend and eventsToExclude. It only makes sense to choose one of these options.
Contributor
|
Ok, I honestly didn't see this PR, because I created a basically identical one here 😅 : #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #11