Repository navigation
feat(react-native): support full Swift Package Manager integration - #4505
Merged
Merged
Conversation
Contributor
Replay incident risk checkThis diff touches code involved in past incidents. This is a heads-up, not a verdict: read the matched sections of INCIDENTS.md and answer their review questions before merging. For a judgment on whether this diff has the same failure mode, run the |
Contributor
Contributor
|
Size Change: 0 B Total Size: 19.3 MB ℹ️ View Unchanged
|
marandaneto
marked this pull request as ready for review
August 12, 2026 14:09
Contributor
Prompt To Fix All With AI### Issue 1
examples/example-rn-spm/README.md:6
**Document the tested SPM command**
The README specifies `npx react-native spm -- deintegrate`, while CI validates `npx react-native spm add --deintegrate --yes`, so following the fixture documentation does not reproduce the tested conversion and invokes the CLI with different arguments.
```suggestion
with `npx react-native spm add --deintegrate --yes` before building it.
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "ci: allow current PostHog packages in Sw..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
marandaneto
commented
Aug 12, 2026
Contributor
🦔 ReviewHog reviewed this pull requestFound 0 must fix, 0 should fix, 1 consider. Published 1 finding (view the review). |
Contributor
|
ReviewHog Alpha 🦔 If you find any issues helpful - please reply "valid", "invalid", etc., for evaluation purposes 🙏 |
![posthog[bot]](https://avatars.githubusercontent.com/in/1203049?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ReviewHog Report
Feature
Issues: 1 issue
Files (6)
packages/react-native-plugin/ios/Package.swiftpackages/react-native-plugin/ios/PosthogReactNativePlugin.swiftpackages/react-native-plugin/posthog-react-native-plugin.podspecpackages/react-native-plugin/scripts/check-spm-manifest.mjspackages/react-native-plugin/package.json.changeset/react-native-full-spm.md
What were the main changes
- Add a hand-written SwiftPM Package.swift with separate Swift implementation target (PosthogReactNativePlugin) and Objective-C++ registration bridge target (PosthogReactNativePluginBridge), since SwiftPM cannot compile Swift and Objective-C++ in one target
- Mark PosthogReactNativePlugin class and its overridden RCTEventEmitter methods
publicso the Swift package's separate bridge target can subclass/access it across module boundaries - Resolve posthog-ios via SwiftPM at the same minimum version (3.69.2) used by the podspec, pinned to Swift 5 language mode to match CocoaPods integration
- Narrow podspec source_files glob now that Package.swift lives alongside the plugin sources and must be excluded from CocoaPods builds
- Add check-spm-manifest.mjs validation script (run via test:unit) asserting the podspec and Package.swift posthog-ios version floors match and required package/product names and Swift language mode are preserved
dustinbyrne
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
React Native 0.87 can use Swift Package Manager for the full iOS native dependency graph, but
@posthog/react-native-plugincannot be packaged by React Native's automatic scaffolder. The plugin mixes Swift and Objective-C++, which SwiftPM cannot compile in one target. This prevents CocoaPods-free React Native projects from linking the PostHog native module.Changes
posthog-iosthrough SwiftPM at the same minimum version used by the podspec.PosthogReactNativePluginObjective-C class.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Pi. The package uses two SwiftPM targets because Swift and Objective-C++ cannot share one target. The React Native SDK remains JavaScript-only, while its optional native plugin owns the Swift package. Validation included plugin tests, lint, JavaScript builds, manifest and tarball checks, React Native 0.87 SwiftPM conversion, and Debug and Release simulator builds.