fix: return booleans from immediate batch flushes

lib/Consumer/LibCurl.php

@@ -69,16 +69,24 @@ public function flushBatch($messages)
             $payload = gzencode($payload);
         }
 
-        return $this->httpClient->sendRequest(
+        $shouldVerify = $this->options['verify_batch_events_request'] ?? true;
+        $response = $this->httpClient->sendRequest(
             '/batch/',
             $payload,
             [
                 // Send user agent in the form of {library_name}/{library_version} as per RFC 7231.
                 "User-Agent: {$messages[0]['library']}/{$messages[0]['library_version']}",
             ],
             [
-                'shouldVerify' => $this->options['verify_batch_events_request'] ?? true,
+                'shouldVerify' => $shouldVerify,
             ]
-        )->getResponse();
+        );
+
+        if (!$shouldVerify) {
+            return $response->getResponse() !== false;
+        }
+
+        // Keep batch success semantics aligned with HttpClient retry handling and the Socket consumer.
+        return $response->getResponseCode() === 200;
     }
 }

lib/Consumer/Socket.php

@@ -42,7 +42,7 @@ public function flushBatch($batch)
         $socket = $this->createSocket();
 
         if (!$socket) {
-            return;
+            return false;
         }
 
         $payload = $this->payload($batch);
@@ -166,7 +166,7 @@ private function makeRequest($socket, $req, $retry = true)
             $socket = $this->createSocket();
         }
 
-        return true;
+        return false;
     }
 
     /**

test/ConsumerSocketTest.php

@@ -86,6 +86,29 @@ public function testShortTimeout(): void
         $client->__destruct();
     }
 
+    public function testBatchSizeOneConnectionErrorReturnsFalse(): void
+    {
+        $client = new Client(
+            "x",
+            array(
+                "batch_size" => 1,
+                "consumer" => "socket",
+                "host" => "invalid.invalid",
+                "ssl" => false,
+                "timeout" => 0.01,
+            )
+        );
+
+        self::assertFalse(
+            $client->capture(
+                array(
+                    "distinctId" => "some-user",
+                    "event" => "Socket PHP Event",
+                )
+            )
+        );
+    }
+
     public function testProductionProblems(): void
     {
         $client = new Client(

test/MockedHttpClient.php

@@ -114,6 +114,10 @@ public function sendRequest(string $path, ?string $payload, array $extraHeaders
             );
         }
 
+        if ($path === "/batch/") {
+            return new HttpResponse('{"status":1}', 200);
+        }
+
         return parent::sendRequest($path, $payload, $extraHeaders, $requestOptions);
     }
 }

test/PostHogTest.php

@@ -444,6 +444,30 @@ public function testAlias(): void
         );
     }
 
+    public function testAliasReturnsBooleanWhenBatchFlushesImmediately(): void
+    {
+        $httpClient = new MockedHttpClient("app.posthog.com");
+        $client = new Client(
+            self::FAKE_API_KEY,
+            [
+                "debug" => true,
+                "batch_size" => 1,
+            ],
+            $httpClient
+        );
+        PostHog::init(null, null, $client);
+
+        $result = PostHog::alias(
+            array(
+                "alias" => "previous-id",
+                "distinctId" => "user-id",
+            )
+        );
+
+        $this->assertIsBool($result);
+        $this->assertTrue($result);
+    }
+
     public function testTimestamps(): void
     {
         self::assertTrue(