#20: Allow string args in log template function#21
Merged
Conversation
cwschilly
requested changes
Jan 20, 2026
Contributor
cwschilly
left a comment
cwschilly
left a comment
There was a problem hiding this comment.
Looks good; just requesting some changes to the unit test to simplify and confirm everything works
tests/logging/test_logger_string.cc
Outdated
| #include "LoggerTest.hpp" | ||
| #include "pressio-log/core.hpp" | ||
|
|
||
| TEST_F(LoggerTest, Logger_String_Templated) { |
Contributor
There was a problem hiding this comment.
Since we test the individual log levels in a separate unit test, we don't need to run through them all here (they all call the same logging function, so if the formatting works for one, it'll work for them all).
Just pick one level (i.e. SPARSE) and run through some of the permutations you have here (one string, two strings, number and a string).
Contributor
Author
There was a problem hiding this comment.
Changed this to use sparse level for each log.
cwschilly
reviewed
Jan 20, 2026
cwschilly
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I simply removed the
std::to_string()call when printing out the arguments given an error. The ostringstream<<operator already handles strings, numeric types, and most other types, so we don't need to convert the args anyway.