On mobile: focus on searchinput on offcanvas open - #796
Closed
tswfi wants to merge 329 commits into
Closed
Conversation
[IMPROVEMENTS - PART 6] Global quality improvement
[IMPROVEMENTS - PART 7] Global quality improvement
[IMPROVEMENTS - PART 8] Global quality improvement
Refactor and cleanup for upcoming v2 release
[A11Y][ps_mainmenu] improve accessibility
[A11Y][productcomments] improve accessibility
Contributor
|
A large pull request is currently being merged (#803). It includes many fixes and improvements for version 2.0 of Hummingbird. Option 1:
Option 2:
If you have any questions or concerns, please feel free to let us know. Have a great day, and may the power of the bird 🐦 be with you ❤️ |
Contributor
Author
|
this is also against |
Contributor
|
Sorry, in any case, the pull requests are on hold while we merge the large pull request mentioned earlier. We will be happy to review and test everything as soon as our initial work is complete. |
Contributor
|
@tswfi can you rebase please. I change the target to merge into the right branch. |
Contributor
Author
|
rebasing this is not practical. opened a new pr #805 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: someone with better understanding on the offcanvas functionality could chime in on if the timeout is even necessary or not :)