Skip to content

On mobile: focus on searchinput on offcanvas open - #796

Closed
tswfi wants to merge 329 commits into
PrestaShop:developfrom
tswfi:mobile_focus_on_searchinput_on_offcanvas_open
Closed

On mobile: focus on searchinput on offcanvas open#796
tswfi wants to merge 329 commits into
PrestaShop:developfrom
tswfi:mobile_focus_on_searchinput_on_offcanvas_open

Conversation

@tswfi

@tswfi tswfi commented Oct 25, 2025

Copy link
Copy Markdown
Contributor
Questions Answers
Description? On mobile view focus on the searchinput when the offcanvas search is shown. Also clear the search when the offcanvas is hidden
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Touches on issue #734 (the actual issue was already fixed before but when testing I noticed that this could be improved a bit)
Sponsor company
How to test? On mobile view click on the search icon to get the offcanvas search to show, the focus should be on the input field and if a mobile phone is used the keyboard is shown. If input field contains text when closing the view then reopening the view should have the old search cleared and the focus again for a new search.

Note: someone with better understanding on the offcanvas functionality could chime in on if the timeout is even necessary or not :)

@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Oct 25, 2025
@ga-devfront

Copy link
Copy Markdown
Contributor

A large pull request is currently being merged (#803). It includes many fixes and improvements for version 2.0 of Hummingbird.
You have two options regarding this pull request:

Option 1:

  • Wait for the pull request to be merged.
  • Verify that your pull request is still relevant.
  • If it's the case rebase it so that it can be considered by our teams.

Option 2:

  • Target the 1.x branch if you consider this to be an important pull request for version 1 of Hummingbird.

If you have any questions or concerns, please feel free to let us know. Have a great day, and may the power of the bird 🐦 be with you ❤️

@ga-devfront ga-devfront added the Blocked Waiting on another task or dependency. label Nov 4, 2025
@tswfi

tswfi commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

this is also against improvements branch already

@ga-devfront

Copy link
Copy Markdown
Contributor

Sorry, in any case, the pull requests are on hold while we merge the large pull request mentioned earlier. We will be happy to review and test everything as soon as our initial work is complete.

@ga-devfront
ga-devfront changed the base branch from improvements to develop November 10, 2025 13:34
@ga-devfront

Copy link
Copy Markdown
Contributor

@tswfi can you rebase please. I change the target to merge into the right branch.
Thank you for your contribution.

@ga-devfront ga-devfront added Waiting for Rebase and removed Blocked Waiting on another task or dependency. labels Nov 10, 2025
@tswfi

tswfi commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

rebasing this is not practical. opened a new pr #805

@tswfi tswfi closed this Nov 10, 2025
@github-project-automation github-project-automation Bot moved this from Ready for review to Closed in PR Dashboard Nov 10, 2025
@tswfi
tswfi deleted the mobile_focus_on_searchinput_on_offcanvas_open branch November 10, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants